refactor: prepare Android ViewModel creation boundary [WPB-23495]#4868
Merged
Conversation
sbakhtiarov
approved these changes
May 26, 2026
|
yamilmedina
approved these changes
May 26, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4868 +/- ##
===========================================
+ Coverage 51.86% 51.88% +0.01%
===========================================
Files 612 613 +1
Lines 21270 21288 +18
Branches 3413 3414 +1
===========================================
+ Hits 11032 11045 +13
- Misses 9219 9222 +3
- Partials 1019 1021 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-23495
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Summary
Prepares the old login ViewModel creation boundary for the Metro migration.
This PR removes direct
SavedStateHandle.navArgs()usage from the old login base/email/SSO ViewModels and passesLoginNavArgsexplicitly through assisted ViewModel creation. It also moves saved login input persistence behind a smallLoginSavedInputStoreboundary so the ViewModels no longer own the Android saved-state mechanism directly.Changes
wireViewModel(...)helpers for assisted Hilt ViewModel creation from Compose.LoginViewModel,LoginEmailViewModel, andLoginSSOViewModelto receive explicitLoginNavArgs.LoginSavedInputStoreandSavedStateLoginSavedInputStore.LoginEmailViewModel/LoginSSOViewModelwith nav args.SavedStateHandle.navArgs()reads.