Skip to content

refactor: route app ViewModel call sites through local boundary [WPB-23495]#4878

Merged
Garzas merged 4 commits into
developfrom
refactor/app-viewmodel-callsite-boundary
May 28, 2026
Merged

refactor: route app ViewModel call sites through local boundary [WPB-23495]#4878
Garzas merged 4 commits into
developfrom
refactor/app-viewmodel-callsite-boundary

Conversation

@Garzas

@Garzas Garzas commented May 27, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-23495


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

Summary

Routes app-module ViewModel retrieval through the local wireViewModel boundary instead of importing hiltViewModel directly at screen call sites.

This is a mechanical app-layer cleanup step toward isolating Hilt usage behind Wire-owned APIs before replacing the underlying implementation with Metro.

Changes

  • Replaced app-module hiltViewModel(...) call sites with wireViewModel(...).
  • Replaced direct Hilt ViewModel imports with com.wire.android.di.wireViewModel.
  • Left the actual Hilt bridge centralized in AssistedViewModelExt.kt.
  • Kept feature modules unchanged to avoid introducing illegal module dependencies.

@Garzas Garzas requested review from saleniuk and sbakhtiarov May 27, 2026 08:37
@Garzas Garzas self-assigned this May 27, 2026
@Garzas Garzas requested a review from yamilmedina May 27, 2026 08:50
@Garzas Garzas force-pushed the refactor/scoped-viewmodel-metro-boundary branch from aec2195 to 7a87a84 Compare May 28, 2026 07:43
@Garzas Garzas force-pushed the refactor/app-viewmodel-callsite-boundary branch from 53f7ccb to 9cedf70 Compare May 28, 2026 07:49
Base automatically changed from refactor/scoped-viewmodel-metro-boundary to develop May 28, 2026 09:05
@pull-request-size pull-request-size Bot added size/L and removed size/M labels May 28, 2026
@Garzas Garzas enabled auto-merge May 28, 2026 09:11
@pull-request-size pull-request-size Bot added size/M and removed size/L labels May 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Garzas Garzas added this pull request to the merge queue May 28, 2026
Merged via the queue into develop with commit e996b2c May 28, 2026
19 checks passed
@Garzas Garzas deleted the refactor/app-viewmodel-callsite-boundary branch May 28, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants