Skip to content

refactor: settings account metro boundary [WPB-25946]#4889

Merged
Garzas merged 2 commits into
developfrom
refactor/settings-account-metro-boundary
Jun 2, 2026
Merged

refactor: settings account metro boundary [WPB-25946]#4889
Garzas merged 2 commits into
developfrom
refactor/settings-account-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates settings/account ViewModels from Hilt call-site creation to Metro-backed factories.
  • Reuses the existing Metro ViewModel bridge introduced in the settings/debug PR.
  • Adds the Compose test fake wiring needed by the migrated account/debug ViewModel graph.

@Garzas Garzas self-assigned this Jun 1, 2026
Base automatically changed from refactor/settings-debug-metro-boundary to develop June 2, 2026 07:30
@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Jun 2, 2026
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@Garzas Garzas force-pushed the refactor/settings-account-metro-boundary branch from dcc5bca to 88cefd1 Compare June 2, 2026 08:11
@pull-request-size pull-request-size Bot added size/L and removed size/XL labels Jun 2, 2026
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.21%. Comparing base (c0a5126) to head (490b249).

Files with missing lines Patch % Lines
...droid/ui/home/settings/SettingsViewModelFactory.kt 0.00% 129 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4889      +/-   ##
===========================================
- Coverage    51.51%   51.21%   -0.31%     
===========================================
  Files          617      618       +1     
  Lines        21534    21663     +129     
  Branches      3422     3422              
===========================================
  Hits         11094    11094              
- Misses        9414     9543     +129     
  Partials      1026     1026              
Files with missing lines Coverage Δ
...i/home/appLock/forgot/ForgotLockScreenViewModel.kt 95.00% <ø> (ø)
...roid/ui/home/appLock/set/SetLockScreenViewModel.kt 58.33% <ø> (ø)
...appLock/unlock/AppUnlockWithBiometricsViewModel.kt 0.00% <ø> (ø)
...ui/home/appLock/unlock/EnterLockScreenViewModel.kt 0.00% <ø> (ø)
...wire/android/ui/home/settings/SettingsViewModel.kt 0.00% <ø> (ø)
...oid/ui/home/settings/account/MyAccountViewModel.kt 90.00% <ø> (ø)
...settings/account/color/ChangeUserColorViewModel.kt 91.66% <ø> (ø)
...gs/account/deleteAccount/DeleteAccountViewModel.kt 87.50% <ø> (ø)
.../account/displayname/ChangeDisplayNameViewModel.kt 96.00% <ø> (ø)
.../account/email/updateEmail/ChangeEmailViewModel.kt 89.74% <ø> (ø)
... and 16 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a5126...490b249. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Jun 2, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas enabled auto-merge June 2, 2026 09:41
@Garzas Garzas added this pull request to the merge queue Jun 2, 2026
Merged via the queue into develop with commit 9290477 Jun 2, 2026
20 checks passed
@Garzas Garzas deleted the refactor/settings-account-metro-boundary branch June 2, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants