Skip to content

refactor: migrate home list view models to metro [WPB-25946]#4892

Merged
Garzas merged 1 commit into
developfrom
refactor/home-list-metro-boundary
Jun 2, 2026
Merged

refactor: migrate home list view models to metro [WPB-25946]#4892
Garzas merged 1 commit into
developfrom
refactor/home-list-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates home shell and conversation list ViewModels from Hilt call-site creation to Metro-backed factories.
  • Adds the required Metro graph wiring for home/list screen entry points.
  • Keeps existing UI-facing ViewModel APIs unchanged.

@Garzas Garzas requested review from sbakhtiarov and yamilmedina June 1, 2026 07:22
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.88235% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.40%. Comparing base (b654cf1) to head (3b842c5).

Files with missing lines Patch % Lines
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% 64 Missing ⚠️

❌ Your patch check has failed because the patch coverage (5.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4892      +/-   ##
===========================================
- Coverage    50.54%   50.40%   -0.15%     
===========================================
  Files          625      626       +1     
  Lines        22129    22192      +63     
  Branches      3427     3427              
===========================================
  Hits         11186    11186              
- Misses        9906     9969      +63     
  Partials      1037     1037              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 76.00% <100.00%> (ø)
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 82.97% <ø> (ø)
...ome/conversationslist/ConversationListViewModel.kt 35.26% <100.00%> (+0.18%) ⬆️
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 93.02% <ø> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 59.44% <100.00%> (ø)
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b654cf1...3b842c5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara force-pushed the refactor/home-list-metro-boundary branch from 506f579 to 3b842c5 Compare June 2, 2026 17:20
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas added this pull request to the merge queue Jun 2, 2026
Merged via the queue into develop with commit 8526836 Jun 2, 2026
20 checks passed
@Garzas Garzas deleted the refactor/home-list-metro-boundary branch June 2, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants