Skip to content

refactor: migrate conversation core view models to metro [WPB-25946]#4893

Merged
Garzas merged 4 commits into
developfrom
refactor/conversation-core-metro-boundary
Jun 2, 2026
Merged

refactor: migrate conversation core view models to metro [WPB-25946]#4893
Garzas merged 4 commits into
developfrom
refactor/conversation-core-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates core conversation screen ViewModels from Hilt call-site creation to Metro-backed factories.
  • Covers messages, composer, drafts, send flow, attachments, and asset-related conversation core wiring.
  • Keeps existing state/effect contracts and screen call sites behaviorally unchanged.

@Garzas Garzas requested review from saleniuk and sbakhtiarov June 1, 2026 07:23
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.08333% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.55%. Comparing base (0b602a2) to head (2b079df).

Files with missing lines Patch % Lines
.../conversations/ConversationCoreViewModelFactory.kt 0.00% 141 Missing ⚠️

❌ Your patch check has failed because the patch coverage (2.08%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4893      +/-   ##
===========================================
- Coverage    50.88%   50.55%   -0.33%     
===========================================
  Files          619      620       +1     
  Lines        21803    21944     +141     
  Branches      3422     3422              
===========================================
  Hits         11094    11094              
- Misses        9683     9824     +141     
  Partials      1026     1026              
Files with missing lines Coverage Δ
...rsations/attachment/MessageAttachmentsViewModel.kt 45.71% <ø> (ø)
...conversations/composer/MessageComposerViewModel.kt 75.26% <ø> (ø)
...rsations/messages/ConversationMessagesViewModel.kt 68.78% <ø> (ø)
...versations/messages/draft/MessageDraftViewModel.kt 69.44% <100.00%> (ø)
...s/messages/item/ConversationAssetPathsViewModel.kt 74.19% <100.00%> (ø)
...ations/migration/ConversationMigrationViewModel.kt 100.00% <100.00%> (ø)
.../conversations/sendmessage/SendMessageViewModel.kt 76.98% <ø> (ø)
.../conversations/ConversationCoreViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b602a2...2b079df. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size Bot added size/S and removed size/M labels Jun 1, 2026
@Garzas Garzas force-pushed the refactor/conversation-core-metro-boundary branch from 721902b to cfdfa21 Compare June 2, 2026 09:53
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Jun 2, 2026
@Garzas Garzas requested a review from saleniuk June 2, 2026 10:01
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jun 2, 2026
@Garzas Garzas force-pushed the refactor/conversation-core-metro-boundary branch from eaf9c01 to 64bec35 Compare June 2, 2026 11:12
@pull-request-size pull-request-size Bot added size/M and removed size/L labels Jun 2, 2026
@Garzas Garzas force-pushed the refactor/conversation-core-metro-boundary branch from 64bec35 to 2b079df Compare June 2, 2026 11:40
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas added this pull request to the merge queue Jun 2, 2026
Merged via the queue into develop with commit 4a6dcb7 Jun 2, 2026
20 checks passed
@Garzas Garzas deleted the refactor/conversation-core-metro-boundary branch June 2, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants