Skip to content

refactor: migrate conversation details view models to metro [WPB-25946]#4894

Merged
Garzas merged 1 commit into
developfrom
refactor/conversation-details-metro-boundary
Jun 2, 2026
Merged

refactor: migrate conversation details view models to metro [WPB-25946]#4894
Garzas merged 1 commit into
developfrom
refactor/conversation-details-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates conversation details ViewModels from Hilt call-site creation to Metro-backed factories.
  • Covers conversation info/details, participants, guest access, metadata, and related details screens.
  • Keeps existing screen contracts and navigation behavior unchanged.

@Garzas Garzas requested review from ohassine and yamilmedina June 1, 2026 07:23
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.31915% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.07%. Comparing base (a6b32ea) to head (d424adb).

Files with missing lines Patch % Lines
...nversations/ConversationDetailsViewModelFactory.kt 0.00% 88 Missing ⚠️
...ails/metadata/EditConversationMetadataViewModel.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (5.31%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4894      +/-   ##
===========================================
- Coverage    50.26%   50.07%   -0.20%     
===========================================
  Files          627      628       +1     
  Lines        22246    22334      +88     
  Branches      3427     3427              
===========================================
  Hits         11183    11183              
- Misses       10026    10114      +88     
  Partials      1037     1037              
Files with missing lines Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 88.97% <ø> (ø)
...etails/editguestaccess/EditGuestAccessViewModel.kt 76.11% <ø> (ø)
...ectedGuestLink/CreatePasswordGuestLinkViewModel.kt 84.84% <100.00%> (ø)
...etingmessages/EditSelfDeletingMessagesViewModel.kt 78.33% <ø> (ø)
...ations/details/options/GroupConversationOptions.kt 0.00% <ø> (ø)
...icipants/GroupConversationParticipantsViewModel.kt 100.00% <100.00%> (ø)
...ails/updateappsaccess/UpdateAppsAccessViewModel.kt 90.29% <100.00%> (ø)
...pdatechannelaccess/UpdateChannelAccessViewModel.kt 100.00% <100.00%> (ø)
...ersations/media/CheckAssetRestrictionsViewModel.kt 72.22% <100.00%> (ø)
...ails/metadata/EditConversationMetadataViewModel.kt 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b32ea...d424adb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas requested a review from saleniuk June 2, 2026 17:57
@Garzas Garzas force-pushed the refactor/conversation-details-metro-boundary branch from e85740f to d424adb Compare June 2, 2026 21:00
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas merged commit 4c06c32 into develop Jun 2, 2026
20 checks passed
@Garzas Garzas deleted the refactor/conversation-details-metro-boundary branch June 2, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants