Skip to content

refactor: migrate conversation search folder view models to metro [WPB-25946]#4895

Merged
Garzas merged 2 commits into
developfrom
refactor/conversation-search-folder-metro-boundary
Jun 2, 2026
Merged

refactor: migrate conversation search folder view models to metro [WPB-25946]#4895
Garzas merged 2 commits into
developfrom
refactor/conversation-search-folder-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates conversation search and folder ViewModels from Hilt call-site creation to Metro-backed factories.
  • Covers message/user/app search, folder management, and move-to-folder wiring.
  • Keeps existing screen contracts and assisted arguments behavior unchanged.

@Garzas Garzas requested review from sbakhtiarov and yamilmedina June 1, 2026 07:24
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.45946% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.93%. Comparing base (4c06c32) to head (6198c23).

Files with missing lines Patch % Lines
...ations/ConversationSearchFolderViewModelFactory.kt 0.00% 63 Missing ⚠️
...home/conversations/folder/ConversationFoldersVM.kt 0.00% 2 Missing ⚠️
...conversations/folder/MoveConversationToFolderVM.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (9.45%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4895      +/-   ##
===========================================
- Coverage    50.07%   49.93%   -0.15%     
===========================================
  Files          628      629       +1     
  Lines        22334    22397      +63     
  Branches      3427     3427              
===========================================
  Hits         11183    11183              
- Misses       10114    10177      +63     
  Partials      1037     1037              
Files with missing lines Coverage Δ
...ui/home/conversations/folder/NewFolderViewModel.kt 100.00% <100.00%> (ø)
...onversations/promoteadmin/PromoteAdminViewModel.kt 94.91% <100.00%> (ø)
...i/home/conversations/search/SearchUserViewModel.kt 97.26% <100.00%> (ø)
...oconversation/AddMembersToConversationViewModel.kt 95.00% <100.00%> (ø)
...e/conversations/search/apps/SearchAppsViewModel.kt 98.07% <100.00%> (ø)
...ch/messages/SearchConversationMessagesViewModel.kt 100.00% <100.00%> (ø)
...home/conversations/folder/ConversationFoldersVM.kt 0.00% <0.00%> (ø)
...conversations/folder/MoveConversationToFolderVM.kt 0.00% <0.00%> (ø)
...ations/ConversationSearchFolderViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c06c32...6198c23. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas requested review from MohamadJaara and saleniuk June 2, 2026 17:53
@Garzas Garzas force-pushed the refactor/conversation-search-folder-metro-boundary branch from 0574f1c to 58e5f2e Compare June 2, 2026 21:31
@Garzas Garzas force-pushed the refactor/conversation-search-folder-metro-boundary branch from 58e5f2e to 21662e1 Compare June 2, 2026 21:34
@Garzas Garzas force-pushed the refactor/conversation-search-folder-metro-boundary branch from 3a7b3e6 to 6198c23 Compare June 2, 2026 22:18
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas merged commit 01ae52b into develop Jun 2, 2026
17 checks passed
@Garzas Garzas deleted the refactor/conversation-search-folder-metro-boundary branch June 2, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants