Skip to content

refactor: migrate scoped message view models to metro [WPB-25946]#4896

Merged
Garzas merged 3 commits into
developfrom
refactor/scoped-message-metro-boundary
Jun 2, 2026
Merged

refactor: migrate scoped message view models to metro [WPB-25946]#4896
Garzas merged 3 commits into
developfrom
refactor/scoped-message-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates scoped message and composer ViewModels from Hilt assisted factories to Metro-backed Resaca creation.
  • Adds ScopedMessageViewModelFactory and graph accessors while preserving scoped lifecycle behavior.
  • Keeps preview/Espresso fallback behavior in the shared scoped ViewModel helper.

@Garzas Garzas requested review from saleniuk and sbakhtiarov June 1, 2026 07:25
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.94030% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.26%. Comparing base (4227187) to head (12efeb8).

Files with missing lines Patch % Lines
...ome/conversations/ScopedMessageViewModelFactory.kt 0.00% 57 Missing ⚠️
.../conversations/edit/MessageOptionsMenuViewModel.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (11.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4896      +/-   ##
===========================================
- Coverage    50.40%   50.26%   -0.14%     
===========================================
  Files          626      627       +1     
  Lines        22192    22246      +54     
  Branches      3427     3427              
===========================================
- Hits         11186    11183       -3     
- Misses        9969    10026      +57     
  Partials      1037     1037              
Files with missing lines Coverage Δ
...ndroid/media/audiomessage/AudioMessageViewModel.kt 81.13% <100.00%> (ø)
...ui/home/conversations/CompositeMessageViewModel.kt 85.71% <100.00%> (-0.96%) ⬇️
...nversations/edit/MessageOptionsModalSheetLayout.kt 0.00% <ø> (ø)
...id/ui/home/conversations/messages/QuotedMessage.kt 0.00% <ø> (ø)
...ersations/messages/item/AssetLocalPathViewModel.kt 70.83% <100.00%> (ø)
...ndroid/ui/home/conversations/model/MessageTypes.kt 14.28% <ø> (ø)
...tions/model/messagetypes/audio/AudioMessageType.kt 0.00% <ø> (ø)
...e/conversations/typing/TypingIndicatorViewModel.kt 80.00% <100.00%> (-1.25%) ⬇️
...oser/actions/SelfDeletingMessageActionViewModel.kt 86.66% <ø> (-0.84%) ⬇️
...poser/attachments/IsFileSharingEnabledViewModel.kt 92.30% <100.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4227187...12efeb8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread app/src/main/kotlin/com/wire/android/di/ViewModelScoped.kt Outdated
@Garzas Garzas requested a review from MohamadJaara June 2, 2026 17:57
@Garzas Garzas force-pushed the refactor/scoped-message-metro-boundary branch from bb0a5b3 to 414d39c Compare June 2, 2026 18:36
@Garzas Garzas enabled auto-merge June 2, 2026 18:36
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas added this pull request to the merge queue Jun 2, 2026
Merged via the queue into develop with commit a6b32ea Jun 2, 2026
18 checks passed
@Garzas Garzas deleted the refactor/scoped-message-metro-boundary branch June 2, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants