Skip to content

refactor: migrate misc view models to metro [WPB-25946]#4897

Merged
Garzas merged 2 commits into
developfrom
refactor/misc-viewmodels-metro-boundary
Jun 2, 2026
Merged

refactor: migrate misc view models to metro [WPB-25946]#4897
Garzas merged 2 commits into
developfrom
refactor/misc-viewmodels-metro-boundary

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrates remaining smaller ViewModels from Hilt call-site creation to Metro-backed factories.
  • Covers analytics, legal hold, E2EI, sharing import, join conversation, initial sync, and related small screens.
  • Keeps existing UI-facing ViewModel APIs unchanged.

@Garzas Garzas requested review from sbakhtiarov and yamilmedina June 1, 2026 07:26
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.30769% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.81%. Comparing base (01ae52b) to head (0863856).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kotlin/com/wire/android/ui/MiscViewModelFactory.kt 0.00% 54 Missing ⚠️
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 0.00% 2 Missing ⚠️
...gs/devices/e2ei/E2eiCertificateDetailsViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4897      +/-   ##
===========================================
- Coverage    49.93%   49.81%   -0.13%     
===========================================
  Files          629      630       +1     
  Lines        22397    22451      +54     
  Branches      3427     3427              
===========================================
  Hits         11183    11183              
- Misses       10177    10231      +54     
  Partials      1037     1037              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...re/android/ui/analytics/AnalyticsUsageViewModel.kt 92.85% <100.00%> (ø)
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 48.38% <100.00%> (ø)
...ire/android/ui/initialsync/InitialSyncViewModel.kt 82.60% <100.00%> (ø)
...inConversation/JoinConversationViaCodeViewModel.kt 90.00% <100.00%> (ø)
...nConversation/JoinConversationViaDeepLinkDialog.kt 85.71% <ø> (ø)
...ialog/deactivated/LegalHoldDeactivatedViewModel.kt 82.35% <100.00%> (ø)
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 89.15% <100.00%> (ø)
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 34.37% <ø> (ø)
...gs/devices/e2ei/E2eiCertificateDetailsViewModel.kt 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ae52b...0863856. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas requested review from MohamadJaara and saleniuk June 2, 2026 17:58
@Garzas Garzas force-pushed the refactor/misc-viewmodels-metro-boundary branch from 6cc1835 to 0863856 Compare June 2, 2026 22:38
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Garzas Garzas merged commit 9142eb0 into develop Jun 2, 2026
15 checks passed
@Garzas Garzas deleted the refactor/misc-viewmodels-metro-boundary branch June 2, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants