refactor: remaining viewmodels metro boundary [WPB-25946]#4915
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4915 +/- ##
===========================================
- Coverage 49.81% 49.63% -0.18%
===========================================
Files 630 630
Lines 22451 22530 +79
Branches 3427 3427
===========================================
- Hits 11183 11182 -1
- Misses 10231 10311 +80
Partials 1037 1037
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
MohamadJaara
approved these changes
Jun 3, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


https://wearezeta.atlassian.net/browse/WPB-25946
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
This PR continues the Android ViewModel migration from Hilt call sites to the Metro-backed ViewModel graph.
Main changes:
MiscViewModelGraphNewConversationViewModelownership instead of passing it throughMainNavHostCommonViewModelFactory/CommonViewModelGraphfor common UI ViewModelsWhy?
This removes another large part of the Hilt ViewModel surface before the final session-scoped Metro graph work.
The migration keeps the same factory ownership model, but moves ViewModel creation behind explicit graph contracts. That makes the remaining work smaller and prepares the app for replacing the temporary Hilt bridge with a real session-scoped Metro graph.