Skip to content

refactor: nuke hilt [WPB-8645]#4931

Merged
MohamadJaara merged 7 commits into
developfrom
mo/refactor/nuke-hilt
Jun 4, 2026
Merged

refactor: nuke hilt [WPB-8645]#4931
MohamadJaara merged 7 commits into
developfrom
mo/refactor/nuke-hilt

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Jun 4, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-8645

remove hilt from the app for metro

@MohamadJaara MohamadJaara requested a review from a team as a code owner June 4, 2026 11:19
@MohamadJaara MohamadJaara requested review from Garzas, emmaoke-w, saleniuk, sbakhtiarov and typfel and removed request for a team June 4, 2026 11:19
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara force-pushed the mo/refactor/nuke-hilt branch from 6b85347 to 5b718bf Compare June 4, 2026 12:01
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt
#	kalium
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
e996a3aced8de5a826c8dc7f071fccf5d35f6ef2 c4077eb7fc6e4c12e08626684f594f21ac6a581c

Is this intentional?

@MohamadJaara MohamadJaara changed the title Mo/refactor/nuke hilt refactor: nuke hilt [WPB-8645] Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
e996a3aced8de5a826c8dc7f071fccf5d35f6ef2 c4077eb7fc6e4c12e08626684f594f21ac6a581c

Is this intentional?

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.85246% with 217 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.30%. Comparing base (ed4336d) to head (cc956f1).

Files with missing lines Patch % Lines
...i/authentication/AuthenticationViewModelFactory.kt 0.00% 78 Missing ⚠️
...droid/ui/home/settings/SettingsViewModelFactory.kt 0.00% 71 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 24 Missing ⚠️
...otlin/com/wire/android/ui/WireActivityViewModel.kt 69.69% 9 Missing and 1 partial ⚠️
...e/android/services/WireFirebaseMessagingService.kt 0.00% 5 Missing ⚠️
...fication/broadcastreceivers/NomadLogoutReceiver.kt 0.00% 2 Missing ⚠️
...on/broadcastreceivers/NotificationReplyReceiver.kt 0.00% 2 Missing ⚠️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 88.88% 2 Missing ⚠️
...om/wire/android/datastore/UserDataStoreProvider.kt 0.00% 1 Missing ⚠️
.../wire/android/emm/ManagedConfigurationsReporter.kt 0.00% 1 Missing ⚠️
... and 21 more

❌ Your patch check has failed because the patch coverage (28.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4931      +/-   ##
===========================================
- Coverage    49.34%   49.30%   -0.05%     
===========================================
  Files          646      646              
  Lines        22851    22872      +21     
  Branches      3502     3502              
===========================================
+ Hits         11276    11277       +1     
- Misses       10529    10549      +20     
  Partials      1046     1046              
Files with missing lines Coverage Δ
.../kotlin/com/wire/android/GlobalObserversManager.kt 89.65% <100.00%> (ø)
...cs/FinalizeRegistrationAnalyticsMetadataUseCase.kt 90.00% <ø> (ø)
...d/analytics/RegistrationAnalyticsManagerUseCase.kt 0.00% <ø> (ø)
.../wire/android/config/NomadProfilesFeatureConfig.kt 0.00% <ø> (ø)
...in/com/wire/android/config/ServerConfigProvider.kt 100.00% <100.00%> (ø)
...tlin/com/wire/android/datastore/GlobalDataStore.kt 28.81% <ø> (ø)
.../wire/android/emm/ManagedConfigurationsReceiver.kt 76.00% <100.00%> (ø)
...n/com/wire/android/feature/AccountSwitchUseCase.kt 63.21% <ø> (ø)
.../com/wire/android/feature/DisableAppLockUseCase.kt 100.00% <ø> (ø)
...ire/android/feature/ObserveAppLockConfigUseCase.kt 88.46% <100.00%> (ø)
... and 168 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4336d...cc956f1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@MohamadJaara MohamadJaara enabled auto-merge June 4, 2026 13:35
@MohamadJaara MohamadJaara disabled auto-merge June 4, 2026 14:46
@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 4, 2026
Merged via the queue into develop with commit 6186c3e Jun 4, 2026
20 checks passed
@MohamadJaara MohamadJaara deleted the mo/refactor/nuke-hilt branch June 4, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants