Skip to content

feat(drive): In app image viewer (WPB-25409)#4939

Merged
ohassine merged 9 commits into
developfrom
in-app-image-viewer
Jun 11, 2026
Merged

feat(drive): In app image viewer (WPB-25409)#4939
ohassine merged 9 commits into
developfrom
in-app-image-viewer

Conversation

@ohassine

@ohassine ohassine commented Jun 9, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-25409


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Open images in an in-app image viewer instead of relying on other apps by intents

Screen_recording_20260609_110504.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine added 2 commits May 13, 2026 19:46
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	kalium
@ohassine ohassine requested review from saleniuk and sbakhtiarov June 9, 2026 11:15
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jun 10, 2026
@ohassine ohassine requested a review from saleniuk June 10, 2026 13:54
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelGraph.kt
@ohassine ohassine enabled auto-merge June 11, 2026 07:31
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (6d486f9) to head (ff221d9).

Files with missing lines Patch % Lines
...e/cells/ui/imageviewer/CellImageViewerViewModel.kt 0.00% 7 Missing ⚠️
.../android/feature/cells/ui/CellsViewModelFactory.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (35.71%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4939      +/-   ##
===========================================
- Coverage    48.85%   48.84%   -0.01%     
===========================================
  Files          642      643       +1     
  Lines        23012    23026      +14     
  Branches      3519     3521       +2     
===========================================
+ Hits         11243    11248       +5     
- Misses       10722    10731       +9     
  Partials      1047     1047              
Files with missing lines Coverage Δ
...wire/android/feature/cells/ui/CellScreenContent.kt 0.00% <ø> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 45.48% <100.00%> (+0.78%) ⬆️
.../android/feature/cells/ui/CellsViewModelFactory.kt 0.00% <0.00%> (ø)
...e/cells/ui/imageviewer/CellImageViewerViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d486f9...ff221d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine ohassine added this pull request to the merge queue Jun 11, 2026
Merged via the queue into develop with commit 01ce361 Jun 11, 2026
18 of 20 checks passed
@ohassine ohassine deleted the in-app-image-viewer branch June 11, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants