refactor: extract user search into module [WPB-25049]#4956
Merged
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
saleniuk
requested review from
Garzas,
MohamadJaara,
alexandreferris,
sbakhtiarov and
typfel
and removed request for
a team
MohamadJaara
approved these changes
Jun 10, 2026
yamilmedina
approved these changes
Jun 10, 2026
yamilmedina
reviewed
Jun 10, 2026
…ch-into-dedicated-module # Conflicts: # app/src/main/kotlin/com/wire/android/di/metro/AppSessionViewModelGraph.kt # app/src/main/kotlin/com/wire/android/ui/common/CommonViewModelFactory.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationSearchFolderViewModelGraph.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/ScopedMessageViewModelGraph.kt # app/stability/app-devDebug.stability # core/di/src/main/kotlin/com/wire/android/di/ViewModelScoped.kt # core/di/src/main/kotlin/com/wire/android/di/metro/MetroViewModelGraph.kt # core/di/stability/di-debug.stability
|
Garzas
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25049
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
User search logic is inside our
appmodule which makes it unusable by other modules.Solutions
Extracted everything needed for the user search into a dedicated
core/searchmodule, so that it can be re-used by other modules.The PR mainly contains moving classes, ViewModels and Composables related to user searches to a separate module, but it also includes some other changes required to make it work:
ViewModelScopedmoved to common module so that it can be also used in other modules, so the part related toViewModelScopedPreviews, which are generated by ksp, is changed to be a parameter for these functions, so that in each module previews from that module can be passed as aPreviewProviderSearchUsersAndAppsScreenparameters got simplified, removed types so that it's more versatile now and bottom actions extracted out of that composable, so there's no need to pass lambdas that are used by only one specific typeCustomTabsHelper,VisibilityStateorWireSnackbarfinally moved to common module as wellTesting
Test Coverage (Optional)
How to Test
Search for users when creating a new conversation or adding to existing conversation.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.