Skip to content

fix: clear conversation search on open [WPB-14778]#4963

Merged
MohamadJaara merged 5 commits into
developfrom
mo/fix-clear-conversation-list-search
Jun 15, 2026
Merged

fix: clear conversation search on open [WPB-14778]#4963
MohamadJaara merged 5 commits into
developfrom
mo/fix-clear-conversation-list-search

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Jun 12, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-14778

Issue: Conversation list search stayed active after opening a conversation and going back.

Cause: Regression from #4837 (c1b6eea), which stopped clearing search on focus loss to fix keyboard navigation.

Fix: Clear the conversation list search only when opening a conversation, preserving keyboard navigation behavior.

@MohamadJaara MohamadJaara requested review from Garzas and saleniuk June 12, 2026 20:05
@MohamadJaara MohamadJaara marked this pull request as ready for review June 12, 2026 20:06
@MohamadJaara MohamadJaara enabled auto-merge June 12, 2026 20:06
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.93%. Comparing base (85c2529) to head (914ae33).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4963      +/-   ##
===========================================
+ Coverage    48.86%   48.93%   +0.06%     
===========================================
  Files          643      643              
  Lines        23028    23030       +2     
  Branches      3519     3519              
===========================================
+ Hits         11253    11270      +17     
+ Misses       10730    10715      -15     
  Partials      1045     1045              
Files with missing lines Coverage Δ
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 48.38% <100.00%> (+48.38%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c2529...914ae33. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara changed the title fix: clear conversation search on open fix: clear conversation search on open [WPB-14778] Jun 15, 2026
@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@MohamadJaara MohamadJaara force-pushed the mo/fix-clear-conversation-list-search branch from 9bd664f to 4f6775b Compare June 15, 2026 09:33
@sonarqubecloud

Copy link
Copy Markdown

@MohamadJaara MohamadJaara merged commit 6e68f67 into develop Jun 15, 2026
19 checks passed
@MohamadJaara MohamadJaara deleted the mo/fix-clear-conversation-list-search branch June 15, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants