Skip to content

test: applock invalid passphrase(WPB-26428)#4984

Merged
emmaoke-w merged 4 commits into
developfrom
test/WPB-26428-applock-invalid-passphrase
Jun 23, 2026
Merged

test: applock invalid passphrase(WPB-26428)#4984
emmaoke-w merged 4 commits into
developfrom
test/WPB-26428-applock-invalid-passphrase

Conversation

@emmaoke-w

@emmaoke-w emmaoke-w commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-26428


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Migrated App Lock TC-8143, TC-8144, TC-8145, and TC-8146 UI tests to AndroidX
  • Added App Lock page/settings helpers for passcode setup, wrong-passcode validation, enforced app-lock alert handling, and non-changeable toggle verification.
  • Added backend support to enable enforced team App Lock via backend API for test setup.

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@emmaoke-w emmaoke-w requested a review from CinnamonNinja June 22, 2026 08:54
@emmaoke-w emmaoke-w marked this pull request as ready for review June 22, 2026 09:02
@emmaoke-w emmaoke-w requested review from Garzas and MohamadJaara June 22, 2026 09:03
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.92%. Comparing base (0d18523) to head (2e223e5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4984   +/-   ##
========================================
  Coverage    48.92%   48.92%           
========================================
  Files          646      646           
  Lines        23172    23172           
  Branches      3553     3553           
========================================
  Hits         11337    11337           
  Misses       10782    10782           
  Partials      1053     1053           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d18523...2e223e5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CinnamonNinja CinnamonNinja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment for potential improvement.

@emmaoke-w emmaoke-w requested a review from CinnamonNinja June 22, 2026 14:53
@emmaoke-w emmaoke-w enabled auto-merge June 23, 2026 09:20
@emmaoke-w emmaoke-w added this pull request to the merge queue Jun 23, 2026
Merged via the queue into develop with commit 84481d9 Jun 23, 2026
20 checks passed
@emmaoke-w emmaoke-w deleted the test/WPB-26428-applock-invalid-passphrase branch June 23, 2026 09:50
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants