Skip to content

fix: add semantic roles to list and menu controls [WPB-14783]#4985

Merged
MohamadJaara merged 1 commit into
developfrom
fix/accessibility-list-menu-control-roles
Jun 22, 2026
Merged

fix: add semantic roles to list and menu controls [WPB-14783]#4985
MohamadJaara merged 1 commit into
developfrom
fix/accessibility-list-menu-control-roles

Conversation

@Garzas

@Garzas Garzas commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-14783


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Controls in list rows, menu rows, and selectable rows did not always expose a semantic role to accessibility services.
  • Some content descriptions included role words like “button”, which could cause duplicate TalkBack announcements once semantic roles are provided.

Causes (Optional)

  • Shared clickable row components used clickable semantics without an explicit role.
  • A couple of accessibility strings encoded the control role in user-facing text instead of relying on platform semantics.

Solutions

  • Added explicit semantic roles to shared clickable list/menu row components.
  • Added explicit RadioButton roles only at selectable row call sites that actually render radio buttons.
  • Removed role words from affected content descriptions across localized resources.

@Garzas Garzas requested review from saleniuk and sbakhtiarov June 22, 2026 09:39
@Garzas Garzas self-assigned this Jun 22, 2026
@Garzas Garzas force-pushed the fix/accessibility-list-menu-control-roles branch from 3fef619 to bcd2d0d Compare June 22, 2026 11:35
@Garzas Garzas requested a review from MohamadJaara June 22, 2026 12:29
@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 22, 2026
Merged via the queue into develop with commit f83ed5a Jun 22, 2026
21 of 22 checks passed
@MohamadJaara MohamadJaara deleted the fix/accessibility-list-menu-control-roles branch June 22, 2026 12:49
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants