Skip to content

test: fix allure test failure screenshot(WPB-26515)#4994

Merged
emmaoke-w merged 3 commits into
developfrom
fix/WPB-26515-fix-allure-screenshot
Jun 23, 2026
Merged

test: fix allure test failure screenshot(WPB-26515)#4994
emmaoke-w merged 3 commits into
developfrom
fix/WPB-26515-fix-allure-screenshot

Conversation

@emmaoke-w

@emmaoke-w emmaoke-w commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-26515


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Moved common UI test cleanup from @after into a JUnit RuleChain so Allure captures the failed screen before backend cleanup changes the app state. Cleanup still runs after every test, but only after the failure screenshot rule has had a chance to attach the real failure screenshot.

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@emmaoke-w emmaoke-w self-assigned this Jun 23, 2026
@emmaoke-w emmaoke-w marked this pull request as ready for review June 23, 2026 09:18
@emmaoke-w emmaoke-w changed the title Fix: fix allure test failure screenshot(WPB-26515) test: fix allure test failure screenshot(WPB-26515) Jun 23, 2026
@emmaoke-w emmaoke-w enabled auto-merge June 23, 2026 11:09
@emmaoke-w emmaoke-w added this pull request to the merge queue Jun 23, 2026
Merged via the queue into develop with commit 2e1628b Jun 23, 2026
23 of 24 checks passed
@emmaoke-w emmaoke-w deleted the fix/WPB-26515-fix-allure-screenshot branch June 23, 2026 11:27
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants