Skip to content

fix: stuck on connecting vendor specific Logcat restrictions (WPB-26623)#5020

Merged
MohamadJaara merged 4 commits into
developfrom
fix/stuck-connecting-lowend-devices
Jul 2, 2026
Merged

fix: stuck on connecting vendor specific Logcat restrictions (WPB-26623)#5020
MohamadJaara merged 4 commits into
developfrom
fix/stuck-connecting-lowend-devices

Conversation

@yamilmedina

@yamilmedina yamilmedina commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-26623


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some devices cannot go after login, they get stuck on connecting.

Causes (Optional)

After some research, some devices, for instance; Huawei, Honor, have some restrictions for showing logcat logs.
This lead to our starting process to be stuck in those devices, since we start logcat process in our LogWriter mechanism.

Solutions

Starting the logs, datadog (for internal), checking logs enabled config for the session, etc is extensive. We wanted at some point in the past to defer this after the splash screen, so now we do this by:

  • Start a minimal config to trace startup performance.
  • Start the full logging mechanism after the splash screen.
  • Surround the logcat startup process of the writer with error handling, this will avoid crashing, and will be a fallback for these devices with restrictions

Note:

About the log restrictions of some devices:

Attachments (Optional)

Before

Screen_recording_20260701_152530.mp4

After

Screen_recording_20260701_152751.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.95890% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.27%. Comparing base (f8189d5) to head (b45725e).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/main/kotlin/com/wire/android/WireApplication.kt 15.68% 43 Missing ⚠️
...m/wire/android/util/logging/LogFileWriterV1Impl.kt 0.00% 11 Missing ⚠️
...m/wire/android/util/logging/LogFileWriterV2Impl.kt 0.00% 11 Missing ⚠️

❌ Your patch check has failed because the patch coverage (10.95%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5020      +/-   ##
===========================================
- Coverage    49.33%   49.27%   -0.07%     
===========================================
  Files          653      653              
  Lines        23512    23553      +41     
  Branches      3607     3615       +8     
===========================================
+ Hits         11600    11606       +6     
- Misses       10839    10873      +34     
- Partials      1073     1074       +1     
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 56.48% <ø> (ø)
...m/wire/android/util/logging/LogFileWriterV1Impl.kt 0.00% <0.00%> (ø)
...m/wire/android/util/logging/LogFileWriterV2Impl.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/com/wire/android/WireApplication.kt 3.92% <15.68%> (+3.92%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8189d5...b45725e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size Bot added size/M and removed size/S labels Jul 1, 2026
@yamilmedina yamilmedina changed the title fix: stuck on connecting lower end devices (WPB-26623) fix: stuck on connecting vendor specific Logcat restrictions (WPB-26623) Jul 2, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

@MohamadJaara MohamadJaara enabled auto-merge July 2, 2026 12:38
@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 2, 2026
Merged via the queue into develop with commit 6bd53ad Jul 2, 2026
22 of 23 checks passed
@MohamadJaara MohamadJaara deleted the fix/stuck-connecting-lowend-devices branch July 2, 2026 12:56
MohamadJaara pushed a commit that referenced this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants