Skip to content

feat: make network quality handler callable multiple times (WPB-23849)#133

Merged
z-dule merged 3 commits intorelease-10.1from
feat/sifa/WPB-23489-make-network-quality-handler-callable-multiple-times
Feb 19, 2026
Merged

feat: make network quality handler callable multiple times (WPB-23849)#133
z-dule merged 3 commits intorelease-10.1from
feat/sifa/WPB-23489-make-network-quality-handler-callable-multiple-times

Conversation

@sifa-wire
Copy link
Contributor

@sifa-wire sifa-wire commented Feb 16, 2026

Make network quality handler callable multiple times.

Add unit test to check functionality. Since newly added test runs slow, it is moved into a new test binary ztest-slow to enable independent test runs, regular (ztest) and slow (ztest-slow) version.

Building

sifa.ozen@Wire-323515:~/wire/wire-avs$ make test
mk/test.mk:79: warning: overriding recipe for target '/home/sifa.ozen/wire/wire-avs/build/linux-x86_64/obj/test/main.o'
mk/test.mk:63: warning: ignoring old recipe for target '/home/sifa.ozen/wire/wire-avs/build/linux-x86_64/obj/test/main.o'

Tests

sifa.ozen@Wire-323515:~/wire/wire-avs$ ./ztest
[==========] Running 151 tests from 28 test cases.
[----------] Global test environment set-up.
...
[----------] 5 tests from cryptoboxtest (62 ms total)

[----------] Global test environment tear-down
[==========] 151 tests from 28 test cases ran. (547 ms total)
[  PASSED  ] 151 tests.

Slow Tests

sifa.ozen@Wire-323515:~/wire/wire-avs$ ./ztest-slow
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from NetworkQuality
[ RUN      ] NetworkQuality.settingHandlerMultipleTimes
wcall: get_members: invalid wuser=0x00000000
[       OK ] NetworkQuality.settingHandlerMultipleTimes (0 ms)
[ RUN      ] NetworkQuality.checkHandlerForDifferentIntervals
wcall: get_members: invalid wuser=0x00000000
wcall((nil)): recv_msg: could not add call: Protocol error
[       OK ] NetworkQuality.checkHandlerForDifferentIntervals (15020 ms)
[----------] 2 tests from NetworkQuality (15020 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (15020 ms total)
[  PASSED  ] 2 tests.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Call set_quality_interval in wcall_set_network_quality_handler
in order to make subsequent changes be effective.
Add unit test for checking network quality handler functionality.
Test is written to check setting handler multiple times with
different intervals.
Move network qality handler tests into ztest-slow binary so that
tests can be run independently.
@sifa-wire sifa-wire requested a review from a team as a code owner February 16, 2026 08:22
@sonarqubecloud
Copy link

@sifa-wire sifa-wire changed the title Feat/sifa/wpb 23489 make network quality handler callable multiple times [WPB-23489] make network quality handler callable multiple times Feb 16, 2026
@sifa-wire sifa-wire changed the title [WPB-23489] make network quality handler callable multiple times feat: make network quality handler callable multiple times (WPB-23849) Feb 16, 2026
Copy link
Contributor

@z-dule z-dule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z-dule z-dule merged commit ed09e72 into release-10.1 Feb 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants