Skip to content

fix: crash calleventstatus - WPB-10449#2233

Merged
netbe merged 15 commits intodevelopfrom
fix/crash-calleventstatus
Jan 16, 2025
Merged

fix: crash calleventstatus - WPB-10449#2233
netbe merged 15 commits intodevelopfrom
fix/crash-calleventstatus

Conversation

@netbe
Copy link
Copy Markdown
Collaborator

@netbe netbe commented Dec 2, 2024 •
edited
Loading

BugWPB-10449 Crash on ZMTimer - CallEventStatus

Issue

There is a crash (see ticket) involving CallEventStatus that happens from time to time. Looking at the usage of CallEventStatus, it appears we don't really need this at all. This PR cleans up unused code in order to resolve the crash.

Testing

  • running app and check for regression

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@netbe netbe self-assigned this Dec 2, 2024
@netbe netbe marked this pull request as draft December 2, 2024 14:50
netbe
netbe commented Dec 2, 2024
View reviewed changes
Comment thread wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift Outdated
netbe
netbe commented Dec 2, 2024
View reviewed changes
Comment thread wire-ios-sync-engine/Source/Notifications/VoIPPushManager.swift Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024 •
edited
Loading

Test Results

    3 files      3 suites   2m 21s ⏱️
2 051 tests 2 048 ✅ 2 💤 1 ❌
2 051 runs  2 049 ✅ 2 💤 0 ❌

For more details on these failures, see this check.

Results for commit a921213.

♻️ This comment has been updated with latest results.

@netbe netbe changed the title WIP - fix crash calleventstatus fix: crash calleventstatus - WPB-10449 Dec 20, 2024
@echoes-hq echoes-hq Bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 20, 2024
@netbe netbe changed the base branch from release/cycle-3.114 to release/cycle-3.115 December 20, 2024 08:43
@echoes-hq echoes-hq Bot added echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. labels Dec 20, 2024
@netbe netbe changed the base branch from release/cycle-3.115 to develop December 20, 2024 08:44
@netbe netbe force-pushed the fix/crash-calleventstatus branch from db256ac to b1b0aed Compare December 20, 2024 15:12
@netbe netbe force-pushed the fix/crash-calleventstatus branch from bf0e86f to febbcf2 Compare January 9, 2025 13:59
netbe
netbe commented Jan 9, 2025
View reviewed changes
Comment thread wire-ios-sync-engine/Source/Synchronization/ZMOperatonLoop+Background.swift
netbe
netbe commented Jan 9, 2025
View reviewed changes
Comment thread wire-ios-sync-engine/Source/Notifications/VoIPPushManager.swift
@netbe netbe marked this pull request as ready for review January 9, 2025 14:07
@netbe netbe requested review from a team, KaterinaWire, caldrian and samwyndham and removed request for a team January 9, 2025 14:07
samwyndham
samwyndham reviewed Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass and looks good but I guess we need to resolve @johnxnguyens points first and maybe add back some of the code that was removed?

@netbe netbe requested a review from johnxnguyen January 13, 2025 15:39
johnxnguyen
johnxnguyen approved these changes Jan 13, 2025
View reviewed changes
Comment thread wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift Outdated
@netbe netbe requested a review from samwyndham January 14, 2025 15:37
@netbe netbe enabled auto-merge January 14, 2025 15:38
@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Jan 15, 2025 •
edited
Loading

Datadog Report

Branch report: fix/crash-calleventstatus
Commit report: 5e8be44
Test service: wire-ios-mono

✅ 0 Failed, 2014 Passed, 2 Skipped, 2m 6.69s Total Time

samwyndham
samwyndham approved these changes Jan 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🛁!

@netbe netbe added this pull request to the merge queue Jan 16, 2025
Merged via the queue into develop with commit 3d1dd34 Jan 16, 2025
@netbe netbe deleted the fix/crash-calleventstatus branch January 16, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwyndham samwyndham samwyndham approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@caldrian caldrian Awaiting requested review from caldrian caldrian was automatically assigned from wireapp/ios

@KaterinaWire KaterinaWire Awaiting requested review from KaterinaWire KaterinaWire was automatically assigned from wireapp/ios

Assignees

@netbe netbe

Labels

echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. echoes: unplanned Any work item that isn’t part of the product or technical roadmap.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@netbe @samwyndham @johnxnguyen