Skip to content

feat: Add sha256 in CI for C builds - WPB-11313#2269

Merged
KaterinaWire merged 13 commits intodevelopfrom
chore/add-sha256-c-builds
Dec 18, 2024
Merged

feat: Add sha256 in CI for C builds - WPB-11313#2269
KaterinaWire merged 13 commits intodevelopfrom
chore/add-sha256-c-builds

Conversation

@KaterinaWire
Copy link
Copy Markdown
Contributor

@KaterinaWire KaterinaWire commented Dec 10, 2024 •
edited by github-actions Bot
Loading

TaskWPB-11313 Add sha256 in iOS CI especially for C builds

Issue

We need to provide sha256 for C builds. This PR adds it to the build notification.

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq Bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Dec 10, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d49428e.

♻️ This comment has been updated with latest results.

netbe
netbe reviewed Dec 10, 2024
View reviewed changes
Comment thread fastlane/Fastfile Outdated
netbe
netbe approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

caldrian
caldrian approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@caldrian caldrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not relevant for 3.115?

@netbe
Copy link
Copy Markdown
Collaborator

netbe commented Dec 18, 2024

Is this not relevant for 3.115?

@KaterinaWire this should be added to 3.112.0 branch, as it's where we'll need it for C builds

@KaterinaWire KaterinaWire added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit d880595 Dec 18, 2024
@KaterinaWire KaterinaWire deleted the chore/add-sha256-c-builds branch December 18, 2024 10:56
@KaterinaWire KaterinaWire mentioned this pull request Dec 18, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@netbe netbe netbe approved these changes

@caldrian caldrian caldrian approved these changes

Assignees

@KaterinaWire KaterinaWire

Labels

echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaterinaWire @netbe @caldrian