Skip to content

fix: setting up Countly on main thread - WPB-17530#3220

Merged
caldrian merged 2 commits into
release/cycle-4.1from
fix/setting-up-countly-on-main-thread-WPB-17530
Jun 19, 2025
Merged

fix: setting up Countly on main thread - WPB-17530#3220
caldrian merged 2 commits into
release/cycle-4.1from
fix/setting-up-countly-on-main-thread-WPB-17530

Conversation

@caldrian
Copy link
Copy Markdown
Contributor

@caldrian caldrian commented Jun 18, 2025 •
edited by github-actions Bot
Loading

StoryWPB-17530 [iOS] New Registration Flows - Personal account countly tracking

Issue

PR #3159 introduced the issue that Countly is setup on a background thread.
This PR fixes it.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian enabled auto-merge (squash) June 18, 2025 19:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 18, 2025 •
edited
Loading

Test Results

3 161 tests   3 134 ✅  3m 35s ⏱️
  444 suites     27 💤
    3 files        0 ❌

Results for commit cc387da.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Jun 18, 2025

Datadog Report

Branch report: fix/setting-up-countly-on-main-thread-WPB-17530
Commit report: a948442
Test service: wire-ios-mono

✅ 0 Failed, 3134 Passed, 27 Skipped, 2m 21.98s Total Time

netbe
netbe approved these changes Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@caldrian caldrian merged commit 7b103dc into release/cycle-4.1 Jun 19, 2025
10 checks passed
@caldrian caldrian deleted the fix/setting-up-countly-on-main-thread-WPB-17530 branch June 19, 2025 10:10
zenkins pushed a commit that referenced this pull request Jun 19, 2025
@caldrian @github-actions
fix: setting up Countly on main thread - WPB-17530 (#3220)
6372f27
zenkins pushed a commit that referenced this pull request Jun 19, 2025
@caldrian @github-actions
fix: setting up Countly on main thread - WPB-17530 (#3220)
cee065c
zenkins pushed a commit that referenced this pull request Jun 19, 2025
@caldrian @github-actions
fix: setting up Countly on main thread - WPB-17530 (#3220)
0901701
@github-actions github-actions Bot mentioned this pull request Jun 19, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@netbe netbe netbe approved these changes

@KaterinaWire KaterinaWire KaterinaWire approved these changes

Assignees

@caldrian caldrian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caldrian @netbe @KaterinaWire