Skip to content

fix: connections requests not working - WPB-18159#3225

Merged
caldrian merged 1 commit into
release/cycle-4.1from
fix/connections-requests-not-working-cherry-pick
Jun 20, 2025
Merged

fix: connections requests not working - WPB-18159#3225
caldrian merged 1 commit into
release/cycle-4.1from
fix/connections-requests-not-working-cherry-pick

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-18159 [iOS] NSE: connection requests not processed properly

Issue

Context: When receiving a push notification for a connection request, it's not processed correctly when going to to the foreground (request doesn't show up). Another issue is when ignoring a connection request from web client, app shows a notification saying connection was accepted.

Causes: Legacy logic for connections request processing was not correctly ported to new code (see ConnectionRequestStrategy). Also when receiving a push notification we were not properly discarding the connection statuses we don't want to display notifications for.

Solutions: Port legacy code to properly process the connection requests. Add validation criteria in NSE to only handle .pending or .accepted connection statuses.

Testing

Have another user send a connection request
in iOS app, wait for the push notification, tap on it, when going to the foreground, it should correctly show up in the conversation list.
for second bug, same process but from a web client (same user as the iOS app) ignore the connection request
iOS app should not receive any notifications

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Jun 19, 2025

Test Results

3 591 tests   3 564 ✅  4m 5s ⏱️
  575 suites     27 💤
    4 files        0 ❌

Results for commit 30a8ec0.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Jun 19, 2025

Datadog Report

Branch report: fix/connections-requests-not-working-cherry-pick
Commit report: 8032695
Test service: wire-ios-mono

✅ 0 Failed, 3564 Passed, 27 Skipped, 1m 56.31s Total Time

@caldrian caldrian force-pushed the fix/connections-requests-not-working-cherry-pick branch from 296b6c7 to e5aaf23 Compare June 19, 2025 18:38
Co-authored-by: Christoph Aldrian <caldrian@users.noreply.github.com>
Co-authored-by: Christoph Aldrian <christoph.aldrian@wire.com>
@caldrian caldrian changed the base branch from develop to release/cycle-4.1 June 19, 2025 18:41
@caldrian caldrian force-pushed the fix/connections-requests-not-working-cherry-pick branch from e5aaf23 to 30a8ec0 Compare June 19, 2025 18:42
auto-merge was automatically disabled June 19, 2025 19:03

Merge commits are not allowed on this repository

@caldrian caldrian merged commit c40ae0e into release/cycle-4.1 Jun 20, 2025
11 checks passed
@caldrian caldrian deleted the fix/connections-requests-not-working-cherry-pick branch June 20, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants