fix: connections requests not working - WPB-18159#3225
Merged
caldrian merged 1 commit intoJun 20, 2025
Conversation
jullianm
approved these changes
Jun 19, 2025
Contributor
Author
Test Results3 591 tests 3 564 ✅ 4m 5s ⏱️ Results for commit 30a8ec0. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 3564 Passed, 27 Skipped, 1m 56.31s Total Time |
caldrian
pushed a commit
that referenced
this pull request
Jun 19, 2025
296b6c7 to
e5aaf23
Compare
Co-authored-by: Christoph Aldrian <caldrian@users.noreply.github.com> Co-authored-by: Christoph Aldrian <christoph.aldrian@wire.com>
e5aaf23 to
30a8ec0
Compare
caldrian
approved these changes
Jun 19, 2025
auto-merge was automatically disabled
June 19, 2025 19:03
Merge commits are not allowed on this repository
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
Context: When receiving a push notification for a connection request, it's not processed correctly when going to to the foreground (request doesn't show up). Another issue is when ignoring a connection request from web client, app shows a notification saying connection was accepted.
Causes: Legacy logic for connections request processing was not correctly ported to new code (see
ConnectionRequestStrategy). Also when receiving a push notification we were not properly discarding the connection statuses we don't want to display notifications for.Solutions: Port legacy code to properly process the connection requests. Add validation criteria in NSE to only handle
.pendingor.acceptedconnection statuses.Testing
Have another user send a connection request
in iOS app, wait for the push notification, tap on it, when going to the foreground, it should correctly show up in the conversation list.
for second bug, same process but from a web client (same user as the iOS app) ignore the connection request
iOS app should not receive any notifications
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: