-
Notifications
You must be signed in to change notification settings - Fork 24
fix: no whitespace allowed in file renaming - WPB-21698 #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results247 tests 247 ✅ 1m 57s ⏱️ Results for commit f1f6629. ♻️ This comment has been updated with latest results. |
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the best approach. I was thinking we could allow white space at the beginning or end of the file name, but just trim it before sending. What do you think?
@samwyndham yes you're right. done in 223dc96 thanks |
WilhelmOks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a suggestion.
Issue
This PR adds a fix for File renaming where the user could enter and save a file with whitespaces.
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: