Skip to content

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Dec 30, 2025

BugWPB-21698 [iOS] Whitespaces are not being trimmed while using in file name and able to save a filename with just whitespace as well

Issue

This PR adds a fix for File renaming where the user could enter and save a file with whitespaces.

Testing

  • when renaming a file in a cells conv and typing any whitespaces in the input field, save button should be disabled

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, netbe and samwyndham and removed request for a team December 30, 2025 15:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Test Results

247 tests   247 ✅  1m 57s ⏱️
 53 suites    0 💤
  1 files      0 ❌

Results for commit f1f6629.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the best approach. I was thinking we could allow white space at the beginning or end of the file name, but just trim it before sending. What do you think?

@jullianm
Copy link
Contributor Author

jullianm commented Jan 5, 2026

I'm not sure this is the best approach. I was thinking we could allow white space at the beginning or end of the file name, but just trim it before sending. What do you think?

@samwyndham yes you're right. done in 223dc96 thanks

@jullianm jullianm requested a review from samwyndham January 5, 2026 14:29
@jullianm jullianm requested review from WilhelmOks and removed request for netbe January 6, 2026 16:15
@jullianm jullianm enabled auto-merge January 7, 2026 07:09
Copy link
Collaborator

@WilhelmOks WilhelmOks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion.

@jullianm jullianm removed the request for review from samwyndham January 7, 2026 13:14
@jullianm jullianm added this pull request to the merge queue Jan 7, 2026
Merged via the queue into develop with commit 7b45f29 Jan 7, 2026
10 checks passed
@jullianm jullianm deleted the fix/whitespace-file-renaming branch January 7, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants