Skip to content

fix: change the condition to close the call - WPB-24070 🍒#4458

Merged
KaterinaWire merged 3 commits intorelease/cycle-4.17from
fix/close-oneonone-call-via-sft-cherry-pick
Mar 20, 2026
Merged

fix: change the condition to close the call - WPB-24070 🍒#4458
KaterinaWire merged 3 commits intorelease/cycle-4.17from
fix/close-oneonone-call-via-sft-cherry-pick

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-24070 [iOS] Remove the temporary workaround for 1:1 calls over SFT

Issue

  1. Remove the workaround of checking aestab (for MLS conversations, aestab goes from 1 to 0)
  2. Fix the isSelfAnActiveMember(...) method and use QualifiedID as a parameter because the pending proposals may belong to a sub-conversation and we were passing the sub-conversation ID to this method and the result was empty because we don't store sub-conversations in the DB.

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Copy Markdown
Collaborator

@zenkins zenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved cherry-pick PR 🍒.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Mar 19, 2026

Test Results

   18 files  1 177 suites   11m 30s ⏱️
8 770 tests 8 741 ✅ 28 💤 1 ❌
8 782 runs  8 754 ✅ 28 💤 0 ❌

For more details on these failures, see this check.

Results for commit 159672b.

♻️ This comment has been updated with latest results.

Summary: workflow run #23303771741
Allure report (download zip): html-report-28675-fix_close-oneonone-call-via-sft-cherry-pick

@sonarqubecloud
Copy link
Copy Markdown

@KaterinaWire KaterinaWire merged commit e185b1a into release/cycle-4.17 Mar 20, 2026
28 checks passed
@KaterinaWire KaterinaWire deleted the fix/close-oneonone-call-via-sft-cherry-pick branch March 20, 2026 09:00
zenkins pushed a commit that referenced this pull request Mar 20, 2026
Co-authored-by: KaterinaWire <57407805+KaterinaWire@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants