Skip to content

chore: do not check blacklist when loading user session - WPB-24175#4485

Merged
samwyndham merged 26 commits into
developfrom
chore/do-not-check-blacklist-loading-user-session-WPB-24175
Apr 22, 2026
Merged

chore: do not check blacklist when loading user session - WPB-24175#4485
samwyndham merged 26 commits into
developfrom
chore/do-not-check-blacklist-loading-user-session-WPB-24175

Conversation

@samwyndham
Copy link
Copy Markdown
Contributor

@samwyndham samwyndham commented Mar 25, 2026

TaskWPB-24175 [iOS] Don't check whether build is blacklisted as part of loading user session

Issue

When loading a user session we currently check the blacklist. Under poor networking conditions this can lead to poor UX - a user might have to wait 60 seconds on the loading screen before a time out occurs and they are navigated to the conversation screen.

This PR:

  • Removes this check during loading. We already have wiring in place for this check to be done at other times.
  • Introduces CheckBlacklistWorker which intermittently checks the blacklist and cause the block view to be shown if the build is blacklisted for a particular logged in server. The app does a check just after loading the users session then again every 6 hours. It also does re-checks if those have failed (based on network condition changes and every 30 min).
  • Removes the checkBuildBlacklistAction recurring action as this is handled by the above worker
  • Adds a UI test for the basic case of the checklist showing after login.
  • Fixes a race condition that could cause the user to go to the authenticated app state from the blacklist app state.

Testing

  1. Login
  2. Set build number to 0 via Developer menu -> Overrides & quit the app.
  3. Restart
  4. Update required view should display

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

Test Results

    6 files    621 suites   5m 20s ⏱️
3 692 tests 3 663 ✅ 28 💤 1 ❌
3 693 runs  3 665 ✅ 28 💤 0 ❌

For more details on these failures, see this check.

Results for commit f51ac26.

♻️ This comment has been updated with latest results.

Summary: workflow run #23546619988
Allure report (download zip): html-report-28799-chore_do-not-check-blacklist-loading-user-session-WPB-24175

@netbe netbe changed the title chore: do not check blacklist when loading user session WPB-24175 chore: do not check blacklist when loading user session - WPB-24175 Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Test Results – WireFoundationAll

53 tests   53 ✅  9s ⏱️
12 suites   0 💤
 1 files     0 ❌

Results for commit e753cbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Test Results – WireSyncEngine

1 095 tests   1 095 ✅  1m 33s ⏱️
  133 suites      0 💤
    1 files        0 ❌

Results for commit e753cbd.

♻️ This comment has been updated with latest results.

@samwyndham samwyndham requested a review from johnxnguyen April 15, 2026 14:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Test Results – Wire-iOS

1 881 tests   1 854 ✅  2m 8s ⏱️
  301 suites     27 💤
    1 files        0 ❌

Results for commit e753cbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Test Results – WireShareEngine

15 tests   15 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit e753cbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Test Results – WireDomain

  1 files  137 suites   16s ⏱️
536 tests 536 ✅ 0 💤 0 ❌
537 runs  537 ✅ 0 💤 0 ❌

Results for commit e753cbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Test Results – WireUIAll

160 tests   159 ✅  1m 5s ⏱️
 41 suites    1 💤
  1 files      0 ❌

Results for commit e753cbd.

♻️ This comment has been updated with latest results.

@samwyndham samwyndham enabled auto-merge April 15, 2026 14:56
@samwyndham samwyndham added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@samwyndham samwyndham added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 17, 2026
…-session-WPB-24175

# Conflicts:
#	wire-ios/Wire-iOS/Sources/AppStateCalculator.swift
@samwyndham samwyndham enabled auto-merge April 17, 2026 09:59
@sonarqubecloud
Copy link
Copy Markdown

@samwyndham samwyndham added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@samwyndham samwyndham added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@samwyndham samwyndham added this pull request to the merge queue Apr 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026
@samwyndham samwyndham added this pull request to the merge queue Apr 22, 2026
Merged via the queue into develop with commit 6bad3e3 Apr 22, 2026
23 checks passed
@samwyndham samwyndham deleted the chore/do-not-check-blacklist-loading-user-session-WPB-24175 branch April 22, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants