fix: disallow copy/paste on WireAuthentication - WPB-24299#4487
Merged
David-Henner merged 209 commits intorelease/cycle-4.16from Mar 26, 2026
Merged
fix: disallow copy/paste on WireAuthentication - WPB-24299#4487David-Henner merged 209 commits intorelease/cycle-4.16from
David-Henner merged 209 commits intorelease/cycle-4.16from
Conversation
netbe
requested review from
a team,
David-Henner and
caldrian
and removed request for
a team
caldrian
reviewed
Mar 25, 2026
Contributor
caldrian
left a comment
caldrian
left a comment
There was a problem hiding this comment.
Looks like the font size of the text fields doesn't get adjusted anymore.
Contributor
Test Results2 198 tests 2 170 ✅ 3m 31s ⏱️ Results for commit d6f2089. ♻️ This comment has been updated with latest results. Summary: workflow run #23597346685 |
…eImages/DetermineAuthMethodViewTests/testCanExitFlow.1.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testColorSchemeVariants.variant0-dark.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testColorSchemeVariants.variant0-light.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testColorSchemeVariants.variant1-dark.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testColorSchemeVariants.variant1-light.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.accessibility1.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.accessibility2.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.accessibility3.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.accessibility4.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.accessibility5.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.large.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.medium.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.accessibility5.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.large.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.medium.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.small.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.xLarge.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.xSmall.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.xxLarge.png: convert to Git LFS
…eImages/VerificationCodeViewTests/testDynamicTypeVariantsEmptyState.xxxLarge.png: convert to Git LFS
…eImages/ReloginViaEmailViewTests/testReloginViaEmail.dark.png: convert to Git LFS
…eImages/ReloginViaEmailViewTests/testReloginViaEmail.light.png: convert to Git LFS
…eImages/ReloginViaEmailViewTests/testReloginViaEmail_WithProxy.dark.png: convert to Git LFS
…eImages/ReloginViaEmailViewTests/testReloginViaEmail_WithProxy.light.png: convert to Git LFS
…eImages/DetermineAuthMethodViewTests/testDynamicTypeVariants.accessibility2.png: convert to Git LFS
…eImages/LoginViaEmailViewTests/testDynamicTypeVariantsWithoutCreateAccount.xxLarge.png: convert to Git LFS
…eImages/LoginViaEmailViewTests/testDynamicTypeVariantsWithoutCreateAccount.xxxLarge.png: convert to Git LFS
…eImages/ReloginViaEmailViewTests/testReloginViaEmail_WithProxy.dark.png: convert to Git LFS
…eImages/ReloginViaEmailViewTests/testReloginViaEmail_WithProxy.light.png: convert to Git LFS
caldrian
reviewed
Mar 26, 2026
Contributor
caldrian
left a comment
caldrian
left a comment
There was a problem hiding this comment.
Some tests fail now because (placeholder) text is cropped.
Maybe because the frame of the text field is static and doesn't grow with the font settings. Maybe also the inset between border and text is too large.
If you argue that this is not related to this PR I'm happy to approve.
David-Henner
approved these changes
Mar 26, 2026
|
caldrian
approved these changes
Mar 26, 2026
Contributor
caldrian
left a comment
caldrian
left a comment
There was a problem hiding this comment.
Approving, but I guess there must be another fix for the cropped text.
Contributor
fixed here fc741df |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The SecurityFlag.isClipboardEnabled is not passed to WireAuthentication textfields. This PR fixes it.
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: