Skip to content

fix: remove exception for showing "Apps are active" info - WPB-24961#4632

Merged
caldrian merged 2 commits into
release/cycle-4.18from
fix/showing-apps-active-banner-WPB-24961
Apr 24, 2026
Merged

fix: remove exception for showing "Apps are active" info - WPB-24961#4632
caldrian merged 2 commits into
release/cycle-4.18from
fix/showing-apps-active-banner-WPB-24961

Conversation

@caldrian
Copy link
Copy Markdown
Contributor

@caldrian caldrian commented Apr 24, 2026

BugWPB-24961 [iOS] Apps active banner not visible

Issue

Currently we'll only show the banner "Apps are active" in a conversation if there are more participants than the self user and the app/bot.
This PR changes the logic and now we will always show the banner if any app is present.

Testing

Add an app to a conversation and see that the banner is visible.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian requested review from a team and Copilot April 24, 2026 10:22
@caldrian caldrian requested review from KaterinaWire and jullianm and removed request for a team April 24, 2026 10:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the data-model computation for ZMConversation.externalParticipantsState so that group conversations report .visibleApps whenever an app/bot participant is present (including the “self + single app/bot” case), which enables showing the “Apps are active” banner more consistently.

Changes:

  • Removed the special-case that returned an empty external participant state when the only other participant in a group was an app/bot.
  • Adjusted the inline comment describing the remaining exception for non-group conversations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Test Results

    7 files    986 suites   9m 49s ⏱️
7 116 tests 7 088 ✅ 28 💤 0 ❌
7 117 runs  7 089 ✅ 28 💤 0 ❌

Results for commit 7680dce.

♻️ This comment has been updated with latest results.

Summary: workflow run #24886158795
Allure report (download zip): html-report-29512-fix_showing-apps-active-banner-WPB-24961

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Apr 24, 2026

Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1 Test failed

testGroupCases() from WireDataModelTests.ZMConversationExternalParticipantsStateTests   View in Datadog   (Fix with Cursor)
ZMConversationExternalParticipantsStateTests.swift:104: XCTAssertEqual failed: ("ExternalParticipantsState(rawValue: 2)") is not equal to ("ExternalParticipantsState(rawValue: 0)")

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 156e605 | Docs | Give us feedback!

@caldrian caldrian enabled auto-merge (squash) April 24, 2026 11:02
@sonarqubecloud
Copy link
Copy Markdown

@caldrian caldrian requested a review from samwyndham April 24, 2026 11:34
@caldrian caldrian merged commit dcc902a into release/cycle-4.18 Apr 24, 2026
19 checks passed
@caldrian caldrian deleted the fix/showing-apps-active-banner-WPB-24961 branch April 24, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants