fix: remove exception for showing "Apps are active" info - WPB-24961#4632
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the data-model computation for ZMConversation.externalParticipantsState so that group conversations report .visibleApps whenever an app/bot participant is present (including the “self + single app/bot” case), which enables showing the “Apps are active” banner more consistently.
Changes:
- Removed the special-case that returned an empty external participant state when the only other participant in a group was an app/bot.
- Adjusted the inline comment describing the remaining exception for non-group conversations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 7 files 986 suites 9m 49s ⏱️ Results for commit 7680dce. ♻️ This comment has been updated with latest results. Summary: workflow run #24886158795 |
|
|



Issue
Currently we'll only show the banner "Apps are active" in a conversation if there are more participants than the self user and the app/bot.
This PR changes the logic and now we will always show the banner if any app is present.
Testing
Add an app to a conversation and see that the banner is visible.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: