Skip to content

revert: fix: prevent main app from blocking notification extension - WPB-23511#4658

Merged
caldrian merged 1 commit into
release/cycle-4.18from
revert/fix/cc-expiring-activity
Apr 30, 2026
Merged

revert: fix: prevent main app from blocking notification extension - WPB-23511#4658
caldrian merged 1 commit into
release/cycle-4.18from
revert/fix/cc-expiring-activity

Conversation

@caldrian
Copy link
Copy Markdown
Contributor

@caldrian caldrian commented Apr 30, 2026 •
edited by github-actions Bot
Loading

BugWPB-23511 [iOS] NSE is often getting stuck and expiring

Issue

This PR reverts #4572.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian
Revert "fix: prevent main app from blocking notification extension - …
472ba75 
…WPB-23511 (#4572)"

This reverts commit c2a9801.

# Conflicts:
#	WireFoundation/Sources/WireUtilitiesPackage/ExpiringActivityRegistration/withExpiringActivity.swift
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – WireUIAll

160 tests   159 ✅  1m 14s ⏱️
 41 suites    1 💤
  1 files      0 ❌

Results for commit 472ba75.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – WireRequestStrategy

  1 files  108 suites   51s ⏱️
965 tests 964 ✅ 0 💤 1 ❌
965 runs  965 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit 472ba75.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – WireDomain

  1 files  136 suites   18s ⏱️
530 tests 530 ✅ 0 💤 0 ❌
531 runs  531 ✅ 0 💤 0 ❌

Results for commit 472ba75.

@caldrian caldrian requested a review from David-Henner April 30, 2026 08:37
@caldrian caldrian enabled auto-merge (squash) April 30, 2026 08:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – WireDataModel

    1 files    245 suites   3m 58s ⏱️
2 377 tests 2 376 ✅ 0 💤 1 ❌
2 377 runs  2 377 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit 472ba75.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – WireAuthenticationAll

106 tests   106 ✅  13s ⏱️
 22 suites    0 💤
  1 files      0 ❌

Results for commit 472ba75.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – WireSyncEngine

1 097 tests   1 097 ✅  1m 30s ⏱️
  133 suites      0 💤
    1 files        0 ❌

Results for commit 472ba75.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results – Wire-iOS

1 881 tests   1 854 ✅  2m 35s ⏱️
  301 suites     27 💤
    1 files        0 ❌

Results for commit 472ba75.

@caldrian caldrian merged commit 16e75a5 into release/cycle-4.18 Apr 30, 2026
29 checks passed
@caldrian caldrian deleted the revert/fix/cc-expiring-activity branch April 30, 2026 08:56
@github-actions github-actions Bot mentioned this pull request Apr 30, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwyndham samwyndham samwyndham approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@David-Henner David-Henner Awaiting requested review from David-Henner

Assignees

@caldrian caldrian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caldrian @samwyndham @johnxnguyen