Skip to content

[helm] Introduce glue for the less copy&pasta approach#412

Merged
lucendio merged 2 commits intodevelopfrom
add-helm-to-cpasta-automation
Feb 10, 2021
Merged

[helm] Introduce glue for the less copy&pasta approach#412
lucendio merged 2 commits intodevelopfrom
add-helm-to-cpasta-automation

Conversation

@lucendio
Copy link
Copy Markdown
Contributor

@lucendio lucendio commented Feb 2, 2021

  • added Makefile and docs
  • requires a helmfile.yaml in ${ENV_DIR}

TODO:

  • Add Helmfile to nix as a dependency

The first counter part can be found in https://github.com/zinfra/cailleach/pull/515

@lucendio lucendio marked this pull request as draft February 2, 2021 18:27
@lucendio
Copy link
Copy Markdown
Contributor Author

lucendio commented Feb 2, 2021

I'd like to consolidate all three Makefiles (Terraform, Ansible, Helm) into one and move it into the top-level. Any thoughts on this? /cc @akshaymankar @jschaul

@jschaul
Copy link
Copy Markdown
Member

jschaul commented Feb 2, 2021

I'd like to consolidate all three Makefiles (Terraform, Ansible, Helm) into one and move it into the top-level. Any thoughts on this? /cc @akshaymankar @jschaul

No strong opinions here. Sounds fine to me to consolidate them.

@akshaymankar
Copy link
Copy Markdown
Member

I'd like to consolidate all three Makefiles (Terraform, Ansible, Helm) into one and move it into the top-level. Any thoughts on this? /cc @akshaymankar @jschaul

Sounds like a good idea 💯

@lucendio lucendio marked this pull request as ready for review February 3, 2021 12:43
@lucendio
Copy link
Copy Markdown
Contributor Author

lucendio commented Feb 3, 2021

Great. I'll do this as a follow-up. Anyway, ready to be reviewed now.

Copy link
Copy Markdown
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try this out, as I'm not yet familiar with helm files (maybe someone else is and could review this?). Minor comments on the README.

@jmatsushita
Copy link
Copy Markdown
Contributor

jmatsushita commented Feb 8, 2021

I'd like to consolidate all three Makefiles (Terraform, Ansible, Helm) into one and move it into the top-level. Any thoughts on this?

Definitely in favor of this!

Our current kubespray playbook outputs the kubeconfig in inventory/$CLUSTER/artifacts/admin.conf but this PR seems to expect $(ENV_DIR)/kubeconfig and $(ENV_DIR)/kubeconfig.dec. Can we make sure things align here?

@lucendio
Copy link
Copy Markdown
Contributor Author

lucendio commented Feb 8, 2021

Our current kubespray playbook outputs the kubeconfig in inventory/$CLUSTER/artifacts/admin.conf but this PR seems to expect $(ENV_DIR)/kubeconfig and $(ENV_DIR)/kubeconfig.dec. Can we make sure things align here?

While this is true for Kubespray, it can be changed by setting artifacts_dir and we already have at least one, that has it in its local top-level - facilitated by a script. With this PR, I just adapted the current reality.

I have another local branch, that transforms this script into a play added to ansible/kubernetes.yaml. But this only works when Sops + GnuPG works from within wire-server-deploy. I talked with @arianvp about the necessary steps. Long story short: I feel you and It'll happen along the road :)

@lucendio lucendio requested a review from jschaul February 8, 2021 18:25
* added Makefile and docs
* requires a `helmfile.yaml` in ${ENV_DIR}
@lucendio lucendio force-pushed the add-helm-to-cpasta-automation branch from ac1c082 to bdb812d Compare February 10, 2021 22:35
@lucendio lucendio merged commit 4495a52 into develop Feb 10, 2021
@lucendio lucendio deleted the add-helm-to-cpasta-automation branch February 10, 2021 22:37
jmatsushita pushed a commit that referenced this pull request Mar 3, 2021
[helm] Introduce glue for the less copy&pasta approach

* added Makefile and docs
* requires a `helmfile.yaml` in ${ENV_DIR}
* add Helmfile as nix dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants