Merged
Conversation
jmatsushita
force-pushed
the
ansible_fixes
branch
from
c691eb0 to
cd9d440
Compare
jmatsushita
force-pushed
the
ansible_fixes
branch
from
cd9d440 to
a51eee5
Compare
arianvp
reviewed
Feb 4, 2021
ansible/kubernetes.yml
Outdated
| command: "kubectl annotate node --overwrite {{ inventory_hostname }} {{ item.key }}={{ item.value }}" | ||
| when: node_annotations is defined | ||
| with_dict: node_annotations | ||
| with_dict: node_annotations | default({}) |
Contributor
There was a problem hiding this comment.
Suggested change
| with_dict: node_annotations | default({}) | |
| with_dict: "{{ node_annotations }}" |
As in 5326661
Which I forgot to cherry-pick to develop
Contributor
|
About the localhost change: when Ansible throws looks identical to what Ansible already does with |
lucendio
added a commit
that referenced
this pull request
Mar 31, 2021
at the moment CD skips fakehost plays, because it's not in the inventory; defining some stub is not a nice solution, if the default (implicit) works just fine. I guess we will find out shortly. * this might only work properly with Nix when using Ansible >= v2.9 but that is just a guess atm. We may need to go back to Ansible 2.7 here * partially reverting #415; current guess is that the error "boto required for this module" mentioned in the PR came form running it locally
lucendio
added a commit
that referenced
this pull request
Mar 31, 2021
at the moment CD skips fakehost plays, because it's not in the inventory; defining some stub is not a nice solution, if the default (implicit) works just fine. I guess we will find out shortly. * this might only work properly with Nix when using Ansible >= v2.9 but that is just a guess atm. We may need to go back to Ansible 2.7 here * partially reverting #415; current guess is that the error "boto required for this module" mentioned in the PR came form running it locally
arianvp
pushed a commit
that referenced
this pull request
Apr 16, 2021
at the moment CD skips fakehost plays, because it's not in the inventory; defining some stub is not a nice solution, if the default (implicit) works just fine. I guess we will find out shortly. * this might only work properly with Nix when using Ansible >= v2.9 but that is just a guess atm. We may need to go back to Ansible 2.7 here * partially reverting #415; current guess is that the error "boto required for this module" mentioned in the PR came form running it locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
with_dictfix is to prevent this from happening:The
host: localhostreplacement is to prevent this from happening: