nix: Remove profileEnv

[akshaymankar]

The overridden NIX_PATH doesn't seem to be used anywhere.

[lucendio]

The overridden NIX_PATH doesn't seem to be used anywhere.

I think it is - again.

[akshaymankar]

I am not sure if it is used even in that PR, i see that @arianvp changed the --no-out-link to --out-link .nix-env, but I think it is done so that we nix-store --gc doesn't delete the stuff required for wire-server-deploy. I still see no use of $NIX_PATH or <nixpkgs>.

[arianvp]

NIX_PATH is just there as a weird convenience such that nix-shell -p <package here> works inside the direnv'd directory. It's not needed it was a convenience hack that Florian added.

[akshaymankar]

I am a little unsure on what convenience it provides. Is it just that if you want to runnix-shell -p <something>, it will use the nixpkgs pinned in the repo?

[arianvp]

That's the only convenience yes. I'm not sure if it's worth it.

Especially when nix 3.0 comes (any time now!) with the Flake support; NIX_PATH won't even really exist anymore...

I am convinced we can just remove it. It probably confuses people more than it helps them..

[akshaymankar]

Cool, I will fix conflicts and ask for reviews again soon :)

[akshaymankar]

@arianvp I fixed the conflicts, please feel free to review it and merge if you approve.

[flokli]

Is this unused?

[flokli]

The convenience here also ensures we all use the same terraform minor version, in case we need to nix-shell one of these in.

Is this so much of a burden to not keep around?

[akshaymankar]

Stale. Closing, will reopen if I get bothered by this.