Skip to content

allow custom private terraform snippets during the use of terraform e…#474

Merged
jschaul merged 1 commit intodevelopfrom
custom-terraform
Jul 6, 2021
Merged

allow custom private terraform snippets during the use of terraform e…#474
jschaul merged 1 commit intodevelopfrom
custom-terraform

Conversation

@jschaul
Copy link
Copy Markdown
Member

@jschaul jschaul commented Jun 15, 2021

…nvironment usage

@arianvp
Copy link
Copy Markdown
Contributor

arianvp commented Jul 5, 2021

I think this demonstrates the smell I was a bit worried about and we broadly discussed a few months ago.

@jmatsushita this mostly seems to be a work around for the pattern that we only have tfvars in cailleach at the moment. I think my suggestion to have only modules in wire-server-deploy and have actual terraform code in cailleach call those modules; instead of using just .tfvars is probably a better way to tackle this. Thoughts? That way people can always add additional terraform code in cailleach if needed.

I'm ok with merging this for now; but I think the better way is to actually have the main terraform file in cailleach and have that call modules in wire-server-deploy so that we don't need these kind of workarounds but just let the tool do its job.

@jschaul jschaul merged commit 959f590 into develop Jul 6, 2021
@jschaul jschaul deleted the custom-terraform branch July 6, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants