actually fix nested values for prometheus-operator (cf. #420)#486
Merged
jschaul merged 1 commit intowireapp:developfrom Aug 23, 2021
tjanson:patch-2
Merged
actually fix nested values for prometheus-operator (cf. #420)#486jschaul merged 1 commit intowireapp:developfrom tjanson:patch-2
jschaul merged 1 commit intowireapp:developfrom
tjanson:patch-2
Conversation
Contributor
Author
|
This also needs to be fixed in the docs (not the indentation, but nesting |
Member
|
Thank you! |
jschaul
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time the components' config trees are actually correctly nested under
prometheus-operatorand their respective top levels (e.g.prometheus).For reference, see the values file of
prometheus-operatorat the time.Fix-up for #420.