Skip to content

Refactor ci#771

Merged
julialongtin merged 76 commits intomasterfrom
refactor-ci
Apr 14, 2025
Merged

Refactor ci#771
julialongtin merged 76 commits intomasterfrom
refactor-ci

Conversation

@mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Mar 31, 2025

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Tracking

  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

Use case

@mohitrajain mohitrajain requested review from a team and julialongtin as code owners March 31, 2025 17:27
…ose from, update builds json to q2-2025 and changed sequence for offline.yml
Copy link
Contributor

@Veki301 Veki301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work :)

@mohitrajain mohitrajain requested a review from Veki301 April 14, 2025 13:11
docker://$image_trimmed docker-archive:${image_path} --additional-tag $image
fi
echo "${image_filename}.tar" >> $(realpath "$1")/index.txt
create-build-entry $image_path $1
Copy link
Contributor

@Veki301 Veki301 Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the restoration of .json files, you will have to revert this change, and do a little tweaking where the output of the resulting .json will go
doesnt look like too much changes/work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will require some testing, as for each profile, it has to create the file in a location. The expected $1 has changed in this file as it has changed the way it processes, so I will try to use your script but it won't be the same.

@sonarqubecloud
Copy link

@julialongtin julialongtin merged commit 8766776 into master Apr 14, 2025
6 checks passed
@julialongtin julialongtin deleted the refactor-ci branch April 14, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants