Conversation
zebot
added
the
ok-to-test
Contributor
Author
Thanks ❤️ As said, we'll try to solve the Sonar issues on a higher level at 11 AM. |
There are no team emails which may include them. Thus, we don't need them in this repo.
Otherwise, the templates are created in the abandonned brig folders. This is probably a missing step of migrating email templating to wire-subsystems.
`index.html`, `index.txt` and `index-subject.txt` aren't needed here. Look at the wire-emails project if you need them.
supersven
force-pushed
the
email-templates-v1.0.148
branch
from
010f9f4 to
24b4e7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #4997 which has been closed.
The remaining tasks done here are:
Update the email templates to the latest released version.
The partials folders are new. They contain snippets to be rendered and included into bigger templates. This is required to create lists of certificates for the IdP change emails (a new template on its own).
And, I had to move the script and version file to libs/wire-subsystems to work with the templates folder in wire-subsystems (dd2f8d4). And, ignore some extra files we don't need in dd2f8d4.
Ticket: https://wearezeta.atlassian.net/browse/WPB-22124
Checklist
changelog.d