WPB-18187: Delete app when removing a user from a team#5046
Merged
blackheaven merged 3 commits intodevelopfrom Feb 20, 2026
Merged
WPB-18187: Delete app when removing a user from a team#5046blackheaven merged 3 commits intodevelopfrom
blackheaven merged 3 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
fisx
reviewed
Feb 19, 2026
integration/test/Test/Apps.hs
Outdated
| bindResponse (deleteTeamMember tid owner appIdObject) $ \resp -> do | ||
| resp.status `shouldMatchInt` 202 | ||
|
|
||
| bindResponse (getApp owner tid appId) $ \resp -> do |
Contributor
There was a problem hiding this comment.
Did you also make sure that both StoredUser and StoredApp have been deleted at this point?
Contributor
There was a problem hiding this comment.
(maybe that would be a good unit test for UserSubsystem.
blackheaven
force-pushed
the
gdifolco/WPB-18187-delete-app-endpoint
branch
from
61cc5d7 to
4482f59
Compare
fisx
approved these changes
Feb 20, 2026
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
now that i understand the problem and context better, i can see a better solution:
- move user deletion login to wire-subsystems (especially the part that is called by galley when deleting teams).
- make a one-line modification to user deletion to make sure that if user is an app, the app table in postgres will also be cleaned up.
but i also realize now that moving stuff to wire-subsystems is not always trivial... :)
the fact that this slows down delete operations is not a big deal either, since deletion is not a very common operation and should only be a small part of brig's and galley's load.
so this is good, i want this solution. 
blackheaven
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-18187
Checklist
changelog.d