saml2-web-sso: fix IdP sample YAML schema and re-enable tests#5061
Merged
battermann merged 3 commits intodevelopfrom Feb 26, 2026
Merged
saml2-web-sso: fix IdP sample YAML schema and re-enable tests#5061battermann merged 3 commits intodevelopfrom
battermann merged 3 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
battermann
changed the title
IdPConfig () ToSchema instance
fisx
approved these changes
Feb 25, 2026
akshaymankar
approved these changes
Feb 25, 2026
Contributor
Author
|
AFAICT the saml2-web-sso unit tests have not been run. This is a requirement for this PR. |
Contributor
Author
I found it, they were run for an earlier commit: https://concourse.ops.zinfra.io/teams/main/pipelines/wire-server-pr/jobs/wire-server-compile-nix/builds/3403 |
battermann
deleted the
battermann/fix-saml2-web-sso-idp-schema-instance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d