WPB-23789: Wrap Galley updateLocalConversation#5075
Merged
blackheaven merged 5 commits intodevelopfrom Mar 3, 2026
Merged
Conversation
zebot
added
the
ok-to-test
fisx
approved these changes
Mar 2, 2026
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
not small, but neat! :)
perhaps you can to motivate the change in the changelog? otherwise good 👍
Contributor
|
The CI failures look almost legit / non-fake, though. 🤔 |
battermann
approved these changes
Mar 3, 2026
Comment on lines
+1
to
+2
| Refactor: introduce specific wrapper functions for `updateLocalConversation` instead of using type applications. | ||
| The idea is to progressively move away from singletons to type class to allow progressive migration to `wire-subsystems`. |
Contributor
There was a problem hiding this comment.
To me this is too specific for a changelog. This could be in the PR description, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23789
Checklist
changelog.d