Move reading/writing of user passwords to UserStore#5079
Merged
akshaymankar merged 1 commit intodevelopfrom Mar 5, 2026
Merged
Move reading/writing of user passwords to UserStore#5079akshaymankar merged 1 commit intodevelopfrom
akshaymankar merged 1 commit intodevelopfrom
Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
delete-password-store
branch
2 times, most recently
from
10d01ab to
c9de0eb
Compare
akshaymankar
force-pushed
the
delete-password-store
branch
3 times, most recently
from
033a12f to
c8c87bf
Compare
akshaymankar
changed the title
akshaymankar
force-pushed
the
delete-password-store
branch
4 times, most recently
from
5ae83cd to
e40a618
Compare
akshaymankar
force-pushed
the
delete-password-store
branch
from
e40a618 to
a2e9943
Compare
battermann
approved these changes
Mar 5, 2026
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
Not production relevant, but I would still suggest to change according to the comment below. Approved proforma.
| @@ -118,7 +128,7 @@ inMemoryUserStoreInterpreter = interpret $ \case | |||
| us' <- f us | |||
| put us' | |||
| DeleteUser user -> modify @[StoredUser] $ filter (\u -> u.id /= User.userId user) | |||
Contributor
There was a problem hiding this comment.
should password be removed here has well?
Member
Author
There was a problem hiding this comment.
The Cassandra interpreter doesn't so I guess not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-22747
Checklist
Add a new entry in an appropriate subdirectory ofNo changelog.changelog.d