WPB-23789: Split performAction in Galley

[blackheaven]

https://wearezeta.atlassian.net/browse/WPB-23789

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

Note: temporary taking another PR as base

[battermann]

I would suggest that you keep a single changelog for all parts of the refactoring, instead of having one changelog per PR. You can add things incrementally in each PR and maybe at the end even just state the overall idea?

[Copilot]

Pull request overview

Refactors Galley’s conversation update flow by removing the centralized performAction dispatcher and inlining action-specific logic into each updateLocalConversation* wrapper, reducing required effect constraints across several APIs.

Changes:

• Removed the top-level performAction function and replaced it with per-wrapper performAction callbacks.
• Updated updateLocalConversation / updateLocalConversationUnchecked to accept the inlined callback (or its Sem result) instead of relying on singleton-based dispatch.
• Simplified effect constraints (and related imports) in multiple API modules where the removed dispatcher previously forced extra dependencies.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
services/galley/src/Galley/API/Action.hs	Removes centralized performAction; threads per-wrapper action execution into updateLocalConversation* and simplifies effect constraints.
services/galley/src/Galley/API/Update.hs	Drops now-unneeded effect constraints from several update endpoints after the refactor.
services/galley/src/Galley/API/Teams.hs	Simplifies deleteTeamConversation constraints consistent with updated delete flow.
services/galley/src/Galley/API/MLS/Reset.hs	Removes unused imports/constraints after the reset path no longer requires them.
services/galley/src/Galley/API/MLS/Commit/InternalCommit.hs	Reduces constraints for internal-commit member removal to match updated unchecked remove-members path.
services/galley/src/Galley/API/LegalHold.hs	Cleans up imports/constraints (notably federation/team-collab related) no longer required after the action refactor.
services/galley/src/Galley/API/Federation.hs	Simplifies leaveConversation constraints after action refactor.
changelog.d/5-internal/WPB-23789-inline-perform-action	Adds changelog entry describing the refactor.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.