WPB-23789: Introduce type class for Galley/Action#5086
Merged
blackheaven merged 5 commits intodevelopfrom Mar 6, 2026
Merged
Conversation
ca0631a to
6a6496f
Compare
battermann
approved these changes
Mar 6, 2026
Contributor
battermann
left a comment
There was a problem hiding this comment.
LGTM, only one suggestion to make the changelog cleaner.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Galley conversation action handling by replacing the large type-family-based constraint mapping with a local type class (IsConversationAction), moving per-action effect constraints and Galley error rows into instances to support incremental migration away from singletons and towards wire-subsystems.
Changes:
- Introduce
IsConversationActionwith associated types for action-specific effects and Galley error rows, and implement instances per action tag. - Refactor
updateLocalConversation*wrappers to delegate toupdateLocalConversationwithout passing an explicitperformActioncallback. - Update
removeMemberFromChannelconstraints and consolidate internal changelog entries into a single file.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/galley/src/Galley/API/Action.hs | Introduces IsConversationAction and refactors action execution to dispatch via type class instances. |
| services/galley/src/Galley/API/Update.hs | Adjusts effect constraints for channel member removal path to include NoChanges. |
| changelog.d/5-internal/WPB-23789-wrap-update-sing | Removes superseded internal changelog entry (now consolidated). |
| changelog.d/5-internal/WPB-23789-inline-perform-action | Removes superseded internal changelog entry (now consolidated). |
| changelog.d/5-internal/WPB-23789 | Adds consolidated internal changelog entry describing the refactor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23789
Checklist
changelog.d