Skip to content

WPB-23789: Drop Galley.Effects#5102

Merged
blackheaven merged 2 commits intodevelopfrom
gdifolco/WPB-23789-drop-galley-effects
Mar 10, 2026
Merged

WPB-23789: Drop Galley.Effects#5102
blackheaven merged 2 commits intodevelopfrom
gdifolco/WPB-23789-drop-galley-effects

Conversation

@blackheaven
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-23789

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven blackheaven requested review from a team as code owners March 9, 2026 17:27
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 9, 2026
@blackheaven blackheaven force-pushed the gdifolco/WPB-23789-drop-galley-effects branch from 7013bbd to 87c5970 Compare March 9, 2026 17:31
import Wire.API.MLS.SubConversation
import Wire.API.Routes.Public.Galley.MLS
import Wire.BackendNotificationQueueAccess
import Wire.ConversationStore qualified as Eff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the alias name Eff still justified when e.g. Wire.ProposalStore is not Eff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed!

Thanks

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from gdifolco/WPB-23789-drop-intra-util to develop March 10, 2026 09:05
@blackheaven blackheaven force-pushed the gdifolco/WPB-23789-drop-galley-effects branch from 87c5970 to bca5bd8 Compare March 10, 2026 09:19
@blackheaven blackheaven merged commit 7318ac6 into develop Mar 10, 2026
10 checks passed
@blackheaven blackheaven deleted the gdifolco/WPB-23789-drop-galley-effects branch March 10, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants