Skip to content

WPB-23789: Drop Galley.API.Push#5104

Merged
blackheaven merged 3 commits intodevelopfrom
gdifolco/WPB-23789-drop-galley-api-push
Mar 10, 2026
Merged

WPB-23789: Drop Galley.API.Push#5104
blackheaven merged 3 commits intodevelopfrom
gdifolco/WPB-23789-drop-galley-api-push

Conversation

@blackheaven
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-23789

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven blackheaven requested review from a team as code owners March 10, 2026 09:11
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 10, 2026
Comment on lines +147 to +148
toRecipient' :: Recipient -> V2.Recipient
toRecipient' r =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if you cannot find a better name than ...Prime for this?
toV2Recipient, maybe? 🤔

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in advance. However, the function in https://github.com/wireapp/wire-server/pull/5104/changes#r2910424010 should IMHO be renamed.

@supersven
Copy link
Contributor

@blackheaven Ormolu seems to be unhappy:

+ make lint-all
./tools/ormolu.sh -c
Formatting branch origin/main in services/wire-server-enterprise
ormolu mode: check
language extensions are taken from the resp. cabal files
Checking 8 file(s)…
test/Test/Enterprise/DNS/VerifyDomainSpec.hs...  ok
Formatting branch origin/develop in .
ormolu mode: check
language extensions are taken from the resp. cabal files
Checking 1925 file(s)…
libs/wire-subsystems/src/Wire/MigrationLock.hs...  ok
libs/wire-subsystems/src/Wire/NotificationSubsystem.hs
@@ -41,7 +41,7 @@
  import Wire.API.Team.Member qualified as Mem
  import Wire.Arbitrary
  import Wire.ExternalAccess
- import Wire.StoredConversation (LocalMember (..), BotMember)
+ import Wire.StoredConversation (BotMember, LocalMember (..))

  data Recipient = Recipient
    { recipientUserId :: UserId,
libs/wire-subsystems/src/Wire/NotificationSubsystem.hs...  *** FAILED
tools/test-stats/Main.hs...  ok
ormolu failed on 1 files.

(https://concourse.ops.zinfra.io/builds/121581814#L69aef663:5)

@blackheaven
Copy link
Contributor Author

Thanks, formatting fixed :)

@blackheaven blackheaven force-pushed the gdifolco/WPB-23789-drop-galley-api-mls-commit branch from 503288a to 47fa598 Compare March 10, 2026 14:32
Base automatically changed from gdifolco/WPB-23789-drop-galley-api-mls-commit to develop March 10, 2026 15:29
@blackheaven blackheaven force-pushed the gdifolco/WPB-23789-drop-galley-api-push branch from 5e9db43 to 863cd14 Compare March 10, 2026 15:31
@blackheaven blackheaven merged commit 19b48f7 into develop Mar 10, 2026
10 checks passed
@blackheaven blackheaven deleted the gdifolco/WPB-23789-drop-galley-api-push branch March 10, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants