Merged
Conversation
supersven
reviewed
Mar 10, 2026
Comment on lines
+147
to
+148
| toRecipient' :: Recipient -> V2.Recipient | ||
| toRecipient' r = |
Contributor
There was a problem hiding this comment.
I'm wondering if you cannot find a better name than ...Prime for this?
toV2Recipient, maybe? 🤔
supersven
approved these changes
Mar 10, 2026
Contributor
supersven
left a comment
There was a problem hiding this comment.
Approving in advance. However, the function in https://github.com/wireapp/wire-server/pull/5104/changes#r2910424010 should IMHO be renamed.
Contributor
|
@blackheaven Ormolu seems to be unhappy: (https://concourse.ops.zinfra.io/builds/121581814#L69aef663:5) |
Contributor
Author
|
Thanks, formatting fixed :) |
503288a to
47fa598
Compare
Base automatically changed from
gdifolco/WPB-23789-drop-galley-api-mls-commit
to
develop
March 10, 2026 15:29
5e9db43 to
863cd14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23789
Checklist
changelog.d