Script to render and diff wire-server manifest#5106
Merged
battermann merged 8 commits intodevelopfrom Mar 11, 2026
Merged
Conversation
blackheaven
requested changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds developer tooling to render the wire-server Helm chart into a single manifest and to diff two rendered manifests for before/after comparisons (e.g., comparing live manifests to locally rendered output).
Changes:
- Added
hack/bin/render-manifest.shto render a manifest from an explicit values file. - Added
hack/bin/diff-wire-server-manifests.shto compare two manifests across several resource aspects. - Updated
Makefiletargets to use the new scripts and removed the priorhelm-render-wire-server-resourcesscript/target.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hack/bin/render-manifest.sh | New script to Helm-render wire-server from a provided values file. |
| hack/bin/helm-render-wire-server-resources.sh | Removed legacy script that previously generated values via helmfile and templated the chart. |
| hack/bin/diff-wire-server-manifests.sh | New manifest diff tool producing sectioned diffs for inventory/workloads/services/secrets/configmaps. |
| Makefile | Replaces old render target with render-manifest and adds diff-live-manifest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blackheaven
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23830
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d