Skip to content

Script to render and diff wire-server manifest#5106

Merged
battermann merged 8 commits intodevelopfrom
battermann/diff-helm-manifests
Mar 11, 2026
Merged

Script to render and diff wire-server manifest#5106
battermann merged 8 commits intodevelopfrom
battermann/diff-helm-manifests

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Mar 10, 2026

https://wearezeta.atlassian.net/browse/WPB-23830

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review March 10, 2026 11:25
@battermann battermann requested a review from a team as a code owner March 10, 2026 11:25
@battermann battermann requested a review from smatting March 10, 2026 11:25
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds developer tooling to render the wire-server Helm chart into a single manifest and to diff two rendered manifests for before/after comparisons (e.g., comparing live manifests to locally rendered output).

Changes:

  • Added hack/bin/render-manifest.sh to render a manifest from an explicit values file.
  • Added hack/bin/diff-wire-server-manifests.sh to compare two manifests across several resource aspects.
  • Updated Makefile targets to use the new scripts and removed the prior helm-render-wire-server-resources script/target.

Reviewed changes

Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.

File Description
hack/bin/render-manifest.sh New script to Helm-render wire-server from a provided values file.
hack/bin/helm-render-wire-server-resources.sh Removed legacy script that previously generated values via helmfile and templated the chart.
hack/bin/diff-wire-server-manifests.sh New manifest diff tool producing sectioned diffs for inventory/workloads/services/secrets/configmaps.
Makefile Replaces old render target with render-manifest and adds diff-live-manifest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@battermann battermann requested a review from blackheaven March 10, 2026 16:18
@battermann battermann merged commit 44f7ee9 into develop Mar 11, 2026
10 checks passed
@battermann battermann deleted the battermann/diff-helm-manifests branch March 11, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants