-
Notifications
You must be signed in to change notification settings - Fork 333
WPB-23942 prevent rabbit mq queues creation for client notifications #5116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
battermann
merged 14 commits into
develop
from
WPB-23942-prevent-rabbit-mq-queues-creation-for-client-notifications
Mar 23, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e88751c
consumable notification shared config for brig and gundeck
battermann a920df2
make target to help render helm ci values
battermann f35a1c9
guard setup of consumable notifications queues
battermann 58b5ac5
disable based on setting
battermann 9e90bf2
explicitly enable consumable notifications in tests
battermann 5626f68
changelog
battermann 63d1f86
prevent no-op thread
battermann 767f058
typo
battermann 33a54e3
added docs
battermann 49eb4b4
release notes
battermann bba698d
more efficient test
battermann 002e5d8
clean up make target and script
battermann 1e36f2a
disable consumable notifications
battermann a9ebde6
updated changelog
battermann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Consumable notifications are now disabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #!/usr/bin/env bash | ||
| # best run via make render-wire-server-resources | ||
| # otherwise run make clean-charts and make charts-integration before | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| VALUES_FILE="${VALUES_FILE:-$(mktemp).yaml}" | ||
|
|
||
| # from repo root | ||
| export NAMESPACE_1="${NAMESPACE_1:-test-a}" | ||
| export NAMESPACE_2="${NAMESPACE_2:-test-b}" | ||
| export FEDERATION_DOMAIN_1="${FEDERATION_DOMAIN_1:-integration.example.com}" | ||
| export FEDERATION_DOMAIN_2="${FEDERATION_DOMAIN_2:-integration2.example.com}" | ||
| export FEDERATION_DOMAIN_BASE_1="${FEDERATION_DOMAIN_BASE_1:-example.com}" | ||
| export FEDERATION_DOMAIN_BASE_2="${FEDERATION_DOMAIN_BASE_2:-example.com}" | ||
| export FEDERATION_CA_CERTIFICATE="${FEDERATION_CA_CERTIFICATE:-$(cat services/nginz/integration-test/conf/nginz/integration-ca.pem)}" | ||
| export ENTERPRISE_IMAGE_PULL_SECRET="${ENTERPRISE_IMAGE_PULL_SECRET:-{}}" | ||
|
|
||
| helmfile -f hack/helmfile.yaml.gotmpl \ | ||
| -e default \ | ||
| --skip-deps \ | ||
| -l name=wire-server,namespace="${NAMESPACE_1}" \ | ||
| write-values \ | ||
| --output-file-template "${VALUES_FILE}" | ||
|
|
||
| echo "Rendered values: $VALUES_FILE" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.