[WPB-21432] app refresh cookie requires password

[fisx]

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[battermann]

The swagger docs should to be changed, otherwise good to go.
Approved proforma.

[battermann]

This is a super nitpick, but I don't think we need to test the case without the body. That is why we use servant, right?
Ideally I would pass a Maybe String and then put it in the body, if it is Just, otherwise "password": null or empty JSON object.

[fisx]

i'm confused now, so i'm going to ignore it :)

[battermann]

I meant something along these lines:

Suggested change

	refreshAppCookie :: (MakesValue u) => u -> String -> String -> Maybe Value -> App Response
	refreshAppCookie u tid appId mbBody = do
	req <- baseRequest u Brig Versioned $ joinHttpPath ["teams", tid, "apps", appId, "cookies"]
	submit "POST" req
	submit "POST" $ req & maybe id addJSON mbBody
	refreshAppCookie :: (MakesValue u) => u -> String -> String -> Maybe String -> App Response
	refreshAppCookie u tid appId mPassword = do
	req <- baseRequest u Brig Versioned $ joinHttpPath ["teams", tid, "apps", appId, "cookies"]
	submit "POST" $ req & addJSONObject ["password" .= maybe Aeson.Null Aeson.encode mPassword ]

[fisx]

hum, maybe i'm not confused but opposed? i had it this way before, but wanted to be more flexible in what we send, to test more corner cases.

thanks, but still ignoring you :)