WPB-24075: Add Wire Meetings delete invitation endpoint#5136
Merged
blackheaven merged 4 commits intodevelopfrom Mar 19, 2026
Merged
WPB-24075: Add Wire Meetings delete invitation endpoint#5136blackheaven merged 4 commits intodevelopfrom
blackheaven merged 4 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
battermann
approved these changes
Mar 19, 2026
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
I would suggest to address the set vs list concern.
Otherwise LGTM
integration/test/Test/Meetings.hs
Outdated
Comment on lines
+302
to
+305
| r1 <- postMeetings owner newMeeting | ||
| assertSuccess r1 | ||
|
|
||
| meeting <- assertOne r1.json |
Contributor
There was a problem hiding this comment.
Suggested change
| r1 <- postMeetings owner newMeeting | |
| assertSuccess r1 | |
| meeting <- assertOne r1.json | |
| meeting <- postMeetings owner newMeeting >>= getJSON 200 |
| removeEmailStatement = | ||
| [resultlessStatement| | ||
| UPDATE meetings M | ||
| SET invited_emails = (SELECT array(SELECT unnest(M.invited_emails) EXCEPT SELECT unnest($1 :: text[]))), |
Contributor
There was a problem hiding this comment.
If I understand the code correctly, you treat the invitations as a set here, whereas in the PR for adding invitations, they are treated as a list. Per API it is possible to add duplicate invitations, but once an invitation is removed, the duplicates will be removed as well. I find this a bit inconsistent, and could cause confusion, or surprises. Can we maybe make this more consistent?
Contributor
Author
There was a problem hiding this comment.
I have switched the other to set semantic!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-24075
Checklist
changelog.d