WPB-23789: Split ConversationSubsystem.Interpreter#5145
Merged
blackheaven merged 2 commits intodevelopfrom Mar 23, 2026
Merged
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-23789-split-interpreter
branch
from
01b4f68 to
84860eb
Compare
fisx
approved these changes
Mar 23, 2026
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
This is not changing any behavior, or even implementation logic, correct? Then I trust you @blackheaven and our regression tests to catch any copy pasta I might have missed. 👍
Comment on lines
+3
to
+5
| -- Copyright (C) 2026 Wire Swiss GmbH <opensource@wire.com> | ||
| -- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com> |
Contributor
Author
There was a problem hiding this comment.
Oops, reverted!
| Range 1 1000 Int32 -> | ||
| Maybe (Qualified ConvId) -> | ||
| Sem r (ResultSet (Qualified ConvId)) | ||
| getConversationIdsResultSetImpl lusr maxIds mLastId = do |
Contributor
There was a problem hiding this comment.
Impl is the suffix for top-level declarations that implement a polysmy action fully/directly.
Suggested change
| getConversationIdsResultSetImpl lusr maxIds mLastId = do | |
| getConversationIdsResultSet lusr maxIds mLastId = do |
Contributor
Author
There was a problem hiding this comment.
Thanks, renamed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-24072
Checklist
changelog.d