[WPB-23995] app visibility accross teams#5171
Merged
Conversation
9e075d2 to
1e5d2a1
Compare
1e5d2a1 to
f8f3705
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents app users from creating/being part of user connections across teams by adding an explicit “no apps in connection creation” guard, and it adds an integration test covering cross-team (and optionally cross-domain) scenarios.
Changes:
- Add
ensureNoAppsguard and apply it to local + remote connection creation paths. - Move
ensureNotSameTeamintoBrig.API.Connection.Utiland reuse it fromBrig.API.Connection. - Add an integration test covering cross-team conversations involving apps; add a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services/brig/src/Brig/API/Connection/Util.hs | Introduces ensureNoApps (and exports ensureNotSameTeam) to enforce connection preconditions. |
| services/brig/src/Brig/API/Connection/Remote.hs | Applies ensureNoApps to remote connection creation and updates effect constraints/imports. |
| services/brig/src/Brig/API/Connection.hs | Removes inline ensureNotSameTeam and applies ensureNoApps to local connection creation. |
| integration/test/Test/Apps.hs | Adds a cross-team app conversation integration test. |
| changelog.d/3-bug-fixes/WPB-23995-app-visibility-accross-teams | Documents the behavior change in the changelog entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blackheaven
approved these changes
Apr 9, 2026
Contributor
blackheaven
left a comment
There was a problem hiding this comment.
copilot lints seem legit
a02a3d6 to
f237a9b
Compare
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d