Skip to content

[WPB-23995] app visibility accross teams#5171

Merged
fisx merged 5 commits intodevelopfrom
WPB-23995-app-visibility-accross-teams
Apr 11, 2026
Merged

[WPB-23995] app visibility accross teams#5171
fisx merged 5 commits intodevelopfrom
WPB-23995-app-visibility-accross-teams

Conversation

@fisx
Copy link
Copy Markdown
Contributor

@fisx fisx commented Apr 8, 2026

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 8, 2026
@fisx fisx force-pushed the WPB-23995-app-visibility-accross-teams branch from 9e075d2 to 1e5d2a1 Compare April 8, 2026 11:29
@fisx fisx force-pushed the WPB-23995-app-visibility-accross-teams branch from 1e5d2a1 to f8f3705 Compare April 9, 2026 07:24
@fisx fisx marked this pull request as ready for review April 9, 2026 07:29
@fisx fisx requested review from a team as code owners April 9, 2026 07:29
@fisx fisx requested a review from Copilot April 9, 2026 19:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents app users from creating/being part of user connections across teams by adding an explicit “no apps in connection creation” guard, and it adds an integration test covering cross-team (and optionally cross-domain) scenarios.

Changes:

  • Add ensureNoApps guard and apply it to local + remote connection creation paths.
  • Move ensureNotSameTeam into Brig.API.Connection.Util and reuse it from Brig.API.Connection.
  • Add an integration test covering cross-team conversations involving apps; add a changelog entry.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
services/brig/src/Brig/API/Connection/Util.hs Introduces ensureNoApps (and exports ensureNotSameTeam) to enforce connection preconditions.
services/brig/src/Brig/API/Connection/Remote.hs Applies ensureNoApps to remote connection creation and updates effect constraints/imports.
services/brig/src/Brig/API/Connection.hs Removes inline ensureNotSameTeam and applies ensureNoApps to local connection creation.
integration/test/Test/Apps.hs Adds a cross-team app conversation integration test.
changelog.d/3-bug-fixes/WPB-23995-app-visibility-accross-teams Documents the behavior change in the changelog entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread services/brig/src/Brig/API/Connection/Remote.hs
Comment thread integration/test/Test/Apps.hs
Comment thread integration/test/Test/Apps.hs
Comment thread changelog.d/3-bug-fixes/WPB-23995-app-visibility-accross-teams
Copy link
Copy Markdown
Contributor

@blackheaven blackheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot lints seem legit

@fisx fisx force-pushed the WPB-23995-app-visibility-accross-teams branch from a02a3d6 to f237a9b Compare April 11, 2026 11:51
@fisx fisx merged commit df05bca into develop Apr 11, 2026
10 checks passed
@fisx fisx deleted the WPB-23995-app-visibility-accross-teams branch April 11, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants